Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2831893002: Revert of [serializer/debugger] hide scripts in the snapshot from the debugger. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [serializer/debugger] hide scripts in the snapshot from the debugger. (patchset #5 id:80001 of https://codereview.chromium.org/2826073004/ ) Reason for revert: failure in the custom snapshot build: http://builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/14178 Original issue's description: > [serializer/debugger] hide scripts in the snapshot from the debugger. > > R=jgruber@chromium.org > BUG=v8:6274 > > Review-Url: https://codereview.chromium.org/2826073004 > Cr-Commit-Position: refs/heads/master@{#44745} > Committed: https://chromium.googlesource.com/v8/v8/+/215e668256a205aba7bacf2da8b68ddfc573d3dd TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6274 Review-Url: https://codereview.chromium.org/2831893002 Cr-Commit-Position: refs/heads/master@{#44747} Committed: https://chromium.googlesource.com/v8/v8/+/2295759711b16853b683cb38924a9dd340ac7a8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M src/debug/debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yang
Created Revert of [serializer/debugger] hide scripts in the snapshot from the debugger.
3 years, 8 months ago (2017-04-20 13:54:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831893002/1
3 years, 8 months ago (2017-04-20 13:54:45 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 13:54:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2295759711b16853b683cb38924a9dd340a...

Powered by Google App Engine
This is Rietveld 408576698