Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 2826073004: [serializer/debugger] hide scripts in the snapshot from the debugger. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer/debugger] hide scripts in the snapshot from the debugger. R=jgruber@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2826073004 Cr-Commit-Position: refs/heads/master@{#44745} Committed: https://chromium.googlesource.com/v8/v8/+/215e668256a205aba7bacf2da8b68ddfc573d3dd

Patch Set 1 #

Patch Set 2 : revert stray edit. #

Patch Set 3 : moved script type change to serializer #

Patch Set 4 : comments #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/debug/debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/snapshot/startup-serializer.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Yang
3 years, 8 months ago (2017-04-20 11:51:37 UTC) #1
jgruber
lgtm
3 years, 8 months ago (2017-04-20 12:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826073004/60001
3 years, 8 months ago (2017-04-20 12:10:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/builds/4567) v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-20 12:28:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826073004/80001
3 years, 8 months ago (2017-04-20 13:01:23 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/v8/v8/+/215e668256a205aba7bacf2da8b68ddfc573d3dd
3 years, 8 months ago (2017-04-20 13:27:52 UTC) #13
Yang
3 years, 8 months ago (2017-04-20 13:54:37 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2831893002/ by yangguo@chromium.org.

The reason for reverting is: failure in the custom snapshot build:
http://builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/14178.

Powered by Google App Engine
This is Rietveld 408576698