Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2831773002: Reland [Home] Close the BottomSheet when a URL is loaded on the NTP (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [Home] Close the BottomSheet when a URL is loaded on the NTP This ensures that a click on the doodle will close the BottomSheet. This reverts commit 38ce623f9ffd74711a06046ff47d371e5ca5a48c. Previously the ChromeHomeNewTabPageTest cases were failing because the sheet state was set twice causing the state change observer to be notified while the sheet was still SCROLLING and not at its final resting place. This patch is the same as the original commit except that it ChromeHomeNewTabPageBase does not set the sheet state to PEEK if the URL being loaded is the NTP. BUG=712607 Review-Url: https://codereview.chromium.org/2831773002 Cr-Commit-Position: refs/heads/master@{#466006} Committed: https://chromium.googlesource.com/chromium/src/+/2e59ca5cb92b38cd1fbf209c728f3cb3487b63f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 8 months ago (2017-04-19 21:38:53 UTC) #3
Michael van Ouwerkerk
lgtm
3 years, 8 months ago (2017-04-20 10:59:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831773002/1
3 years, 8 months ago (2017-04-20 14:48:32 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 14:52:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e59ca5cb92b38cd1fbf209c728f...

Powered by Google App Engine
This is Rietveld 408576698