Chromium Code Reviews
DescriptionReland [Home] Close the BottomSheet when a URL is loaded on the NTP
This ensures that a click on the doodle will close the BottomSheet.
This reverts commit 38ce623f9ffd74711a06046ff47d371e5ca5a48c.
Previously the ChromeHomeNewTabPageTest cases were failing because the
sheet state was set twice causing the state change observer to be
notified while the sheet was still SCROLLING and not at its final
resting place. This patch is the same as the original commit except
that it ChromeHomeNewTabPageBase does not set the sheet state to
PEEK if the URL being loaded is the NTP.
BUG=712607
Review-Url: https://codereview.chromium.org/2831773002
Cr-Commit-Position: refs/heads/master@{#466006}
Committed: https://chromium.googlesource.com/chromium/src/+/2e59ca5cb92b38cd1fbf209c728f3cb3487b63f0
Patch Set 1 #
Messages
Total messages: 12 (8 generated)
|
|||||||||||||||||||