Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Issue 2831773002: Reland [Home] Close the BottomSheet when a URL is loaded on the NTP (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
index 4515d9746faf7addecc195bb992be1ad7de7410d..66b409bbcee5d559dd8435f75b6330231135cf0f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.ntp;
import android.content.Context;
import android.support.annotation.CallSuper;
import android.support.annotation.Nullable;
+import android.text.TextUtils;
import android.view.View;
import android.view.View.OnClickListener;
@@ -24,6 +25,7 @@ import org.chromium.chrome.browser.tab.TabObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetMetrics;
+import org.chromium.content_public.browser.LoadUrlParams;
/**
* The base class for the new tab pages displayed in Chrome Home.
@@ -90,6 +92,14 @@ public abstract class ChromeHomeNewTabPageBase implements NativePage {
mFadingBackgroundView.setEnabled(true);
if (!mTab.isClosing()) mShowOverviewOnClose = false;
}
+
+ @Override
+ public void onLoadUrl(Tab tab, LoadUrlParams params, int loadType) {
+ // If the NTP is loading, the sheet state will be set to SHEET_STATE_HALF.
+ if (TextUtils.equals(tab.getUrl(), getUrl())) return;
+
+ mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true);
+ }
};
mTab.addObserver(mTabObserver);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698