Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2831453002: [Extensions Bindings] Move custom handling to APIBindingHooksDelegate (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Move custom handling to APIBindingHooksDelegate Move custom request handling from registering a method in the APIBindingHooks to a delegate call to match CreateCustomEvent. Add a APIBindingHooksTestDelegate for use in unittests to avoid having a bunch of one-off subclasses. BUG=653596 Review-Url: https://codereview.chromium.org/2831453002 Cr-Commit-Position: refs/heads/master@{#465735} Committed: https://chromium.googlesource.com/chromium/src/+/438c2eb7315f961aff2a38c937c8f8c415c40924

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -104 lines) Patch
M extensions/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/api_binding_hooks.h View 3 chunks +1 line, -32 lines 0 comments Download
M extensions/renderer/api_binding_hooks.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M extensions/renderer/api_binding_hooks_delegate.h View 2 chunks +8 lines, -1 line 0 comments Download
M extensions/renderer/api_binding_hooks_delegate.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A extensions/renderer/api_binding_hooks_test_delegate.h View 1 chunk +64 lines, -0 lines 0 comments Download
A extensions/renderer/api_binding_hooks_test_delegate.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M extensions/renderer/api_binding_unittest.cc View 8 chunks +16 lines, -8 lines 0 comments Download
M extensions/renderer/api_bindings_system_unittest.cc View 4 chunks +3 lines, -48 lines 0 comments Download

Messages

Total messages: 29 (24 generated)
Devlin
Mind taking a look? Just a small cleanup.
3 years, 8 months ago (2017-04-19 18:17:26 UTC) #22
jbroman
lgtm
3 years, 8 months ago (2017-04-19 18:26:10 UTC) #23
lazyboy
lgtm
3 years, 8 months ago (2017-04-19 18:50:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831453002/80001
3 years, 8 months ago (2017-04-19 19:39:28 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:39:13 UTC) #29
Message was sent while issue was closed.
Committed patchset #1 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/438c2eb7315f961aff2a38c937c8...

Powered by Google App Engine
This is Rietveld 408576698