[Extensions Bindings] Move custom handling to APIBindingHooksDelegate

extensions/renderer/api_binding_hooks.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_API_BINDING_HOOKS_H_
 #define EXTENSIONS_RENDERER_API_BINDING_HOOKS_H_
 
-#include <map>
 #include <memory>
 #include <string>
 
-#include "base/callback.h"
 #include "base/macros.h"
 #include "extensions/renderer/api_binding_types.h"
-#include "extensions/renderer/argument_spec.h"
 #include "v8/include/v8.h"
 
-namespace gin {
-class Arguments;
-}
-
 namespace extensions {
 class APIBindingHooksDelegate;
+class APITypeReferenceMap;
 class APISignature;
 
 // A class to register custom hooks for given API calls that need different
 // handling. An instance exists for a single API, but can be used across
 // multiple contexts (but only on the same thread).
 // TODO(devlin): We have both C++ and JS custom bindings, but this only allows
 // for registration of C++ handlers. Add JS support.
 class APIBindingHooks {
  public:
   // The result of checking for hooks to handle a request.
@@ skipping 10 matching lines @@
     explicit RequestResult(ResultCode code);
     RequestResult(ResultCode code, v8::Local<v8::Function> custom_callback);
     RequestResult(const RequestResult& other);
     ~RequestResult();
 
     ResultCode code;
     v8::Local<v8::Function> custom_callback;
     v8::Local<v8::Value> return_value;  // Only valid if code == HANDLED.
   };
 
-  // The callback to handle an API method. We pass in the expected signature
-  // (so the caller can verify arguments, optionally after modifying/"massaging"
-  // them) and the passed arguments. The handler is responsible for returning,
-  // which depending on the API could mean either returning synchronously
-  // through gin::Arguments::Return or asynchronously through a passed callback.
-  // TODO(devlin): As we continue expanding the hooks interface, we should allow
-  // handlers to register a request so that they don't have to maintain a
-  // reference to the callback themselves.
-  using HandleRequestHook =
-      base::Callback<RequestResult(const APISignature*,
-                                   v8::Local<v8::Context> context,
-                                   std::vector<v8::Local<v8::Value>>*,
-                                   const APITypeReferenceMap&)>;
-
   APIBindingHooks(const std::string& api_name,
                   const binding::RunJSFunctionSync& run_js);
   ~APIBindingHooks();
 
-  // Register a custom binding to handle requests.
-  // TODO(devlin): Remove this in favor of a method on APIBindingHooksDelegate.
-  void RegisterHandleRequest(const std::string& method_name,
-                             const HandleRequestHook& hook);
-
   // Looks for any custom hooks associated with the given request, and, if any
   // are found, runs them. Returns the result of running the hooks, if any.
   RequestResult RunHooks(const std::string& method_name,
                          v8::Local<v8::Context> context,
                          const APISignature* signature,
                          std::vector<v8::Local<v8::Value>>* arguments,
                          const APITypeReferenceMap& type_refs);
 
   // Returns a JS interface that can be used to register hooks.
   v8::Local<v8::Object> GetJSHookInterface(v8::Local<v8::Context> context);
@@ skipping 10 matching lines @@
 
   void SetDelegate(std::unique_ptr<APIBindingHooksDelegate> delegate);
 
  private:
   // Updates the |arguments| by running |function| and settings arguments to the
   // returned result.
   bool UpdateArguments(v8::Local<v8::Function> function,
                        v8::Local<v8::Context> context,
                        std::vector<v8::Local<v8::Value>>* arguments);
 
-  // Whether we've tried to use any hooks associated with this object.
-  bool hooks_used_ = false;
-
-  // All registered request handlers.
-  std::map<std::string, HandleRequestHook> request_hooks_;
-
   // The name of the associated API.
   std::string api_name_;
 
   // We use synchronous JS execution here because at every point we execute JS,
   // it's in direct response to JS calling in. There should be no reason that
   // script is disabled.
   binding::RunJSFunctionSync run_js_;
 
   std::unique_ptr<APIBindingHooksDelegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(APIBindingHooks);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_API_BINDING_HOOKS_H_