Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2831383002: [Android O] Refactor channel definitions into new class (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Android O] Refactor channel definitions into new class - As discussed, we can give this a per-file OWNERS for added safety in case of channels being updated without increasing the version number. - In future there will also be a requirement to move deprecated channels into a new map, and thus a further need for safety. - This refactoring will also make testing easier as fake channel definitions can now be easily supplied in tests. Review-Url: https://codereview.chromium.org/2832433002 Cr-Commit-Position: refs/heads/master@{#466316} (cherry picked from commit 8aacc8f8d02e5b19f491b34f744085dd2c521167) BUG=710843 Review-Url: https://codereview.chromium.org/2831383002 . Cr-Commit-Position: refs/branch-heads/3071@{#120} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8041f5964cd3de050c62498f25ec559373412161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -262 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelDefinitions.java View 5 chunks +25 lines, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsInitializer.java View 2 chunks +14 lines, -121 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsInitializerTest.java View 1 chunk +38 lines, -38 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java View 3 chunks +14 lines, -15 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
awdf
3 years, 8 months ago (2017-04-21 16:55:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8041f5964cd3de050c62498f25ec559373412161.

Powered by Google App Engine
This is Rietveld 408576698