Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2831373002: Introduce subresource_filter::ConfigurationList and make querying it cheap. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
index d21988ce0e7bc72cec14867c170faa1a40b2d3ad..ab5ca80da4348a89bc77424290bfcc1f1d0548e9 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
@@ -60,7 +60,6 @@
#include "components/safe_browsing_db/v4_feature_list.h"
#include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
#include "components/safe_browsing_db/v4_protocol_manager_util.h"
-#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
#include "components/subresource_filter/core/browser/subresource_filter_features.h"
#include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"
#include "components/subresource_filter/core/common/test_ruleset_creator.h"
@@ -930,10 +929,6 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SubresourceFilterEndToEndTest) {
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- auto* driver_factory = subresource_filter::
- ContentSubresourceFilterDriverFactory::FromWebContents(web_contents);
- driver_factory->set_configuration_for_testing(
- subresource_filter::GetActiveConfiguration());
// Navigation to a phishing page should trigger an interstitial. If the user
// clicks through it, the page load should proceed, but with subresource
@@ -2004,10 +1999,6 @@ IN_PROC_BROWSER_TEST_F(V4SafeBrowsingServiceTest,
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- auto* driver_factory = subresource_filter::
- ContentSubresourceFilterDriverFactory::FromWebContents(web_contents);
- driver_factory->set_configuration_for_testing(
- subresource_filter::GetActiveConfiguration());
// Navigation to a phishing page should trigger an interstitial. If the user
// clicks through it, the page load should proceed, but with subresource

Powered by Google App Engine
This is Rietveld 408576698