Introduce subresource_filter::ConfigurationList and make querying it cheap.

chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test creates a safebrowsing service using test safebrowsing database
 // and a test protocol manager. It is used to test logics in safebrowsing
 // service.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
@@ skipping 42 matching lines @@
 #include "components/prefs/pref_service.h"
 #include "components/safe_browsing/common/safebrowsing_switches.h"
 #include "components/safe_browsing_db/database_manager.h"
 #include "components/safe_browsing_db/metadata.pb.h"
 #include "components/safe_browsing_db/test_database_manager.h"
 #include "components/safe_browsing_db/util.h"
 #include "components/safe_browsing_db/v4_database.h"
 #include "components/safe_browsing_db/v4_feature_list.h"
 #include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
 #include "components/safe_browsing_db/v4_protocol_manager_util.h"
-#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
 #include "components/subresource_filter/core/browser/subresource_filter_features.h"
 #include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"
 #include "components/subresource_filter/core/common/test_ruleset_creator.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "crypto/sha2.h"
@@ skipping 849 matching lines @@
   GURL phishing_url = embedded_test_server()->GetURL(
       "/subresource_filter/frame_with_included_script.html");
   SBFullHashResult malware_full_hash;
   GenUrlFullHashResultWithMetadata(phishing_url, PHISH,
                                    ThreatPatternType::SOCIAL_ENGINEERING_ADS,
                                    &malware_full_hash);
   SetupResponseForUrl(phishing_url, malware_full_hash);
 
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
-  auto* driver_factory = subresource_filter::
-      ContentSubresourceFilterDriverFactory::FromWebContents(web_contents);
-  driver_factory->set_configuration_for_testing(
-      subresource_filter::GetActiveConfiguration());
 
   // Navigation to a phishing page should trigger an interstitial. If the user
   // clicks through it, the page load should proceed, but with subresource
   // filtering activated. This is verified by probing whether `included_script`
   // that is disallowed above indeed fails to load.
   EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(phishing_url)));
   ui_test_utils::NavigateToURL(browser(), phishing_url);
   ASSERT_TRUE(Mock::VerifyAndClearExpectations(&observer_));
   ASSERT_TRUE(got_hit_report());
   content::WaitForInterstitialAttach(web_contents);
@@ skipping 1050 matching lines @@
   ASSERT_NO_FATAL_FAILURE(
       test_ruleset_publisher.SetRuleset(test_ruleset_pair.unindexed));
 
   GURL phishing_url = embedded_test_server()->GetURL(
       "/subresource_filter/frame_with_included_script.html");
   MarkUrlForPhishingUnexpired(phishing_url,
                               ThreatPatternType::SOCIAL_ENGINEERING_ADS);
 
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
-  auto* driver_factory = subresource_filter::
-      ContentSubresourceFilterDriverFactory::FromWebContents(web_contents);
-  driver_factory->set_configuration_for_testing(
-      subresource_filter::GetActiveConfiguration());
 
   // Navigation to a phishing page should trigger an interstitial. If the user
   // clicks through it, the page load should proceed, but with subresource
   // filtering activated. This is verified by probing whether `included_script`
   // that is disallowed above indeed fails to load.
   EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(phishing_url)));
   ui_test_utils::NavigateToURL(browser(), phishing_url);
   ASSERT_TRUE(Mock::VerifyAndClearExpectations(&observer_));
   ASSERT_TRUE(got_hit_report());
   content::WaitForInterstitialAttach(web_contents);
@@ skipping 477 matching lines @@
 }
 
 INSTANTIATE_TEST_CASE_P(
     MaybeSetMetadata,
     V4SafeBrowsingServiceMetadataTest,
     testing::Values(ThreatPatternType::NONE,
                     ThreatPatternType::MALWARE_LANDING,
                     ThreatPatternType::MALWARE_DISTRIBUTION));
 
 }  // namespace safe_browsing