chrome/browser/component_updater/subresource_filter_component_installer.cc - Issue 2831373002: Introduce subresource_filter::ConfigurationList and make querying it cheap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/subresource_filter_component_installer.cc

Issue 2831373002: Introduce subresource_filter::ConfigurationList and make querying it cheap. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/subresource_filter_component_installer.cc

diff --git a/chrome/browser/component_updater/subresource_filter_component_installer.cc b/chrome/browser/component_updater/subresource_filter_component_installer.cc

index 0b3ff980342599cf8443e9dad8e4bc111f3b04a5..a7635db1478e7bb44b010e4b0c83730a1b640e77 100644

--- a/chrome/browser/component_updater/subresource_filter_component_installer.cc

+++ b/chrome/browser/component_updater/subresource_filter_component_installer.cc

@@ -112,8 +112,9 @@ std::string SubresourceFilterComponentInstallerTraits::GetName() const {

// static

std::string SubresourceFilterComponentInstallerTraits::GetInstallerTag() {

- std::string ruleset_flavor =

- subresource_filter::GetActiveConfiguration().ruleset_flavor;

+ std::string ruleset_flavor = subresource_filter::GetActiveConfigurations()

Sorin Jianu 2017/04/24 21:58:59 can this be declared const?

engedy 2017/04/25 08:34:23 Yep, done.

+ ->the_one_and_only()

+ .ruleset_flavor;

if (ruleset_flavor.empty())

return ruleset_flavor;