Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2831243002: Revert of Address some TODO(GYP_GONE)s (Closed)

Created:
3 years, 8 months ago by sgurun-gerrit only
Modified:
3 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, pennymac+watch_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, Michael Moss, jbudorick+watch_chromium.org, jln+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Address some TODO(GYP_GONE)s (patchset #6 id:100001 of https://codereview.chromium.org/2569333002/ ) Reason for revert: breaking android builder, see crbug.com/713915 Original issue's description: > Address some TODO(GYP_GONE)s > > No intended behavior change. If this breaks your bot because it's > trying to build a foo_run target, make it build the corresponding > foo target instead (see diff). > > Depends on https://chromium-review.googlesource.com/#/c/419296/ > > BUG=673897 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=brettw > > Review-Url: https://codereview.chromium.org/2569333002 > Cr-Commit-Position: refs/heads/master@{#466154} > Committed: https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d TBR=dpranke@chromium.org,kbr@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673897 Review-Url: https://codereview.chromium.org/2831243002 Cr-Commit-Position: refs/heads/master@{#466177} Committed: https://chromium.googlesource.com/chromium/src/+/637c7353077c92bbf627b602c57f0e3604525129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+919 lines, -576 lines) Patch
M breakpad/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 5 chunks +38 lines, -2 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 2 chunks +4 lines, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.android.json View 8 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.android.fyi.json View 10 chunks +30 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 18 chunks +54 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 84 chunks +92 lines, -80 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 459 chunks +477 lines, -450 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 7 chunks +21 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 10 chunks +30 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 8 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.chromium.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 39 chunks +39 lines, -39 lines 0 comments Download
M testing/test.gni View 1 chunk +18 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/vector_icons/aggregate_vector_icons.py View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
sgurun-gerrit only
Created Revert of Address some TODO(GYP_GONE)s
3 years, 8 months ago (2017-04-20 22:59:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831243002/1
3 years, 8 months ago (2017-04-20 22:59:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 23:00:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/637c7353077c92bbf627b602c57f...

Powered by Google App Engine
This is Rietveld 408576698