Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2569333002: Address some TODO(GYP_GONE)s (Closed)

Created:
4 years ago by Nico
Modified:
3 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, pennymac+watch_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, Michael Moss, jbudorick+watch_chromium.org, jln+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Address some TODO(GYP_GONE)s No intended behavior change. If this breaks your bot because it's trying to build a foo_run target, make it build the corresponding foo target instead (see diff). Depends on https://chromium-review.googlesource.com/#/c/419296/ BUG=673897 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brettw Review-Url: https://codereview.chromium.org/2569333002 Cr-Original-Commit-Position: refs/heads/master@{#466154} Committed: https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d Review-Url: https://codereview.chromium.org/2569333002 Cr-Commit-Position: refs/heads/master@{#466331} Committed: https://chromium.googlesource.com/chromium/src/+/9cb3b1d088bdd435de0292a58966c4c514acd0a1

Patch Set 1 #

Patch Set 2 : json #

Patch Set 3 : gaaaaah #

Patch Set 4 : end2end #

Patch Set 5 : rebase #

Patch Set 6 : reduce scope a little #

Total comments: 1

Patch Set 7 : reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -883 lines) Patch
M breakpad/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 5 chunks +2 lines, -38 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 3 4 5 6 8 chunks +8 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.android.fyi.json View 1 2 3 4 5 6 10 chunks +10 lines, -10 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 18 chunks +0 lines, -54 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 2 3 4 84 chunks +80 lines, -92 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 2 3 4 459 chunks +450 lines, -477 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 7 chunks +0 lines, -21 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 2 3 4 10 chunks +0 lines, -30 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 8 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/client.v8.chromium.json View 1 2 3 4 5 chunks +0 lines, -15 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 2 3 4 39 chunks +39 lines, -39 lines 0 comments Download
M testing/test.gni View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M ui/vector_icons/aggregate_vector_icons.py View 1 2 3 4 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 50 (37 generated)
Nico
kbr: content/test/gpu/OWNERS dpranke: rest
4 years ago (2016-12-13 22:31:19 UTC) #4
Ken Russell (switch to Gerrit)
That's wonderful. Thank you for cleaning this up. LGTM
4 years ago (2016-12-14 01:25:17 UTC) #18
Dirk Pranke
lgtm, in a rubber-stampy-sort-of-way (I'm relying on kbr's review for some of this). I think ...
4 years ago (2016-12-15 03:14:38 UTC) #19
Nico
I rebased this, and if my build-side CL hasn't been reverted in a few hours ...
3 years, 8 months ago (2017-04-20 18:57:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569333002/100001
3 years, 8 months ago (2017-04-20 21:39:50 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/416923)
3 years, 8 months ago (2017-04-20 21:51:18 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569333002/100001
3 years, 8 months ago (2017-04-20 21:52:50 UTC) #36
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d
3 years, 8 months ago (2017-04-20 21:59:12 UTC) #39
sgurun-gerrit only
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2831243002/ by sgurun@chromium.org. ...
3 years, 8 months ago (2017-04-20 22:59:31 UTC) #40
jbudorick
https://codereview.chromium.org/2569333002/diff/100001/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (left): https://codereview.chromium.org/2569333002/diff/100001/testing/buildbot/chromium.android.json#oldcode1299 testing/buildbot/chromium.android.json:1299: "breakpad_unittests_deps" These all need to stay for now in ...
3 years, 8 months ago (2017-04-20 22:59:54 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569333002/120001
3 years, 8 months ago (2017-04-21 13:49:19 UTC) #46
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/9cb3b1d088bdd435de0292a58966c4c514acd0a1
3 years, 8 months ago (2017-04-21 14:49:19 UTC) #49
Ken Russell (switch to Gerrit)
3 years, 8 months ago (2017-04-21 17:46:29 UTC) #50
Message was sent while issue was closed.
Thanks Nico for pushing this through and doing this nice cleanup!

Powered by Google App Engine
This is Rietveld 408576698