Address some TODO(GYP_GONE)s

Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Original-Commit-Position: refs/heads/master@{#466154}
Committed: https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d
Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466331}
Committed: https://chromium.googlesource.com/chromium/src/+/9cb3b1d088bdd435de0292a58966c4c514acd0a1

[Nico, 2016-12-13 22:10:54]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

BUG=none
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Nico, 2016-12-13 22:30:37]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Nico, 2016-12-13 22:31:18]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org, kbr@chromium.org

[Nico, 2016-12-13 22:31:19]

kbr: content/test/gpu/OWNERS
dpranke: rest

[Nico, 2016-12-13 22:31:23]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:32:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:40:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2016-12-13 22:45:59]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:55:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-12-13 23:21:20]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-12-13 23:26:05]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-13 23:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:47:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-12-14 01:25:17]

That's wonderful. Thank you for cleaning this up. LGTM

[Dirk Pranke, 2016-12-15 03:14:38]

lgtm, in a rubber-stampy-sort-of-way (I'm relying on kbr's review for some of
this).

I think you might need to rebase to merge in the butler change.

Also, see my comments in your build-side CL for the challenges with landing
this.

[Nico, 2017-04-20 18:53:48]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 18:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-20 18:57:03]

I rebased this, and if my build-side CL hasn't been reverted in a few hours I'll
finally land this.

[commit-bot: I haz the power, 2017-04-20 19:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:03:29]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2017-04-20 19:14:47]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 19:15:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:57:25]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-04-20 21:39:10]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-04-20 21:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2569333002/#ps100001
(title: "reduce scope a little")

[commit-bot: I haz the power, 2017-04-20 21:39:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:51:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-04-20 21:51:47]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw
==========

[Nico, 2017-04-20 21:51:53]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:58:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492725113938060,
"parent_rev": "577ecb1d07b3990adc456b13143046561dd86ccc", "commit_rev":
"1d66d232a08315927b4ffb6212c1516c6ddfbe6d"}

[commit-bot: I haz the power, 2017-04-20 21:59:11]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466154}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...
==========

[commit-bot: I haz the power, 2017-04-20 21:59:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...

[sgurun-gerrit only, 2017-04-20 22:59:31]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2831243002/ by sgurun@chromium.org.

The reason for reverting is: breaking android builder, see crbug.com/713915.

[jbudorick, 2017-04-20 22:59:53]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-04-20 22:59:54]

https://codereview.chromium.org/2569333002/diff/100001/testing/buildbot/chrom...
File testing/buildbot/chromium.android.json (left):

https://codereview.chromium.org/2569333002/diff/100001/testing/buildbot/chrom...
testing/buildbot/chromium.android.json:1299: "breakpad_unittests_deps"
These all need to stay for now in some form (i.e., it could also change to
"breakpad_unittests"). The existing recipe logic attempts to append _apk to all
local gtest targets:
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c...

(Your try runs didn't hit this because they're all swarmed, where the recipe
logic appends _apk_run to all gtest targets:
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c....
That exists for breakpad_unittests.)

[Nico, 2017-04-21 13:45:53]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466154}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466154}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...
==========

[Nico, 2017-04-21 13:49:02]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-04-21 13:49:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2569333002/#ps120001
(title: "reland")

[commit-bot: I haz the power, 2017-04-21 13:49:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:48:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492782542971070,
"parent_rev": "3c4223e5e02987afb69c98f56d914ddf9b59da34", "commit_rev":
"9cb3b1d088bdd435de0292a58966c4c514acd0a1"}

[commit-bot: I haz the power, 2017-04-21 14:49:17]

Description was changed from

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466154}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...
==========

to

==========
Address some TODO(GYP_GONE)s

No intended behavior change. If this breaks your bot because it's
trying to build a foo_run target, make it build the corresponding
foo target instead (see diff).

Depends on https://chromium-review.googlesource.com/#/c/419296/

BUG=673897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brettw

Review-Url: https://codereview.chromium.org/2569333002
Cr-Original-Commit-Position: refs/heads/master@{#466154}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1...
Review-Url: https://codereview.chromium.org/2569333002
Cr-Commit-Position: refs/heads/master@{#466331}
Committed:
https://chromium.googlesource.com/chromium/src/+/9cb3b1d088bdd435de0292a58966...
==========

[commit-bot: I haz the power, 2017-04-21 14:49:19]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/9cb3b1d088bdd435de0292a58966...

[Ken Russell (switch to Gerrit), 2017-04-21 17:46:29]

Thanks Nico for pushing this through and doing this nice cleanup!