Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2831103002: Move shared constants to //components/chrome_cleaner (Closed)

Created:
3 years, 8 months ago by ftirelo
Modified:
3 years, 8 months ago
Reviewers:
Sorin Jianu, Joe Mason
CC:
chromium-reviews, alito+watch_chromium.org, ftirelo+watch_chromium.org, csharp+watch_chromium.org, joenotcharles+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shared constants to //components/chrome_cleaner BUG=709035 Review-Url: https://codereview.chromium.org/2831103002 Cr-Commit-Position: refs/heads/master@{#466117} Committed: https://chromium.googlesource.com/chromium/src/+/60ed9879a5363d0413f70b40569a14c7b11f42f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc View 7 chunks +25 lines, -25 lines 0 comments Download
M components/chrome_cleaner/public/constants/constants.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/chrome_cleaner/public/constants/constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ftirelo
3 years, 8 months ago (2017-04-20 17:15:38 UTC) #2
Joe Mason
lgtm
3 years, 8 months ago (2017-04-20 19:01:47 UTC) #3
ftirelo
sorin@chromium.org: Please review changes in component_updater.
3 years, 8 months ago (2017-04-20 19:06:28 UTC) #5
Sorin Jianu
lgtm Thank you!
3 years, 8 months ago (2017-04-20 19:30:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831103002/1
3 years, 8 months ago (2017-04-20 19:36:31 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:43:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60ed9879a5363d0413f70b40569a...

Powered by Google App Engine
This is Rietveld 408576698