Move shared constants to //components/chrome_cleaner

chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/sw_reporter_installer_win.h"
 
 #include <map>
 #include <memory>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/safe_browsing/srt_fetcher_win.h"
+#include "components/chrome_cleaner/public/constants/constants.h"
 #include "components/variations/variations_params_manager.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace component_updater {
 
 namespace {
 
 constexpr char kExperimentGroupName[] = "my_test_engine_group";
 
-constexpr char kEngineExperimentGroupSwitch[] = "engine-experiment-group";
-constexpr char kRegistrySuffixSwitch[] = "registry-suffix";
-constexpr char kSessionIdSwitch[] = "session-id";
-
 constexpr char kErrorHistogramName[] = "SoftwareReporter.ExperimentErrors";
 constexpr char kExperimentTag[] = "experiment_tag";
 constexpr char kMissingTag[] = "missing_tag";
 
 using safe_browsing::SwReporterInvocation;
 
 }  // namespace
 
 class SwReporterInstallerTest : public ::testing::Test {
  public:
@@ skipping 28 matching lines @@
   // Expects that the SwReporter was launched exactly once, with a session-id
   // switch.
   void ExpectDefaultInvocation() const {
     EXPECT_EQ(default_version_, launched_version_);
     ASSERT_EQ(1U, launched_invocations_.size());
 
     const SwReporterInvocation& invocation = launched_invocations_.front();
     EXPECT_EQ(MakeTestFilePath(default_path_),
               invocation.command_line.GetProgram());
     EXPECT_EQ(1U, invocation.command_line.GetSwitches().size());
-    EXPECT_EQ(
-        40U,
-        invocation.command_line.GetSwitchValueASCII(kSessionIdSwitch).size());
+    EXPECT_EQ(40U, invocation.command_line
+                       .GetSwitchValueASCII(chrome_cleaner::kSessionIdSwitch)
+                       .size());
     EXPECT_TRUE(invocation.command_line.GetArgs().empty());
     EXPECT_TRUE(invocation.suffix.empty());
     EXPECT_EQ(SwReporterInvocation::BEHAVIOUR_LOG_EXIT_CODE_TO_PREFS |
                   SwReporterInvocation::BEHAVIOUR_TRIGGER_PROMPT |
                   SwReporterInvocation::BEHAVIOUR_ALLOW_SEND_REPORTER_LOGS,
               invocation.supported_behaviours);
   }
 
   // |ComponentReady| asserts that it is run on the UI thread, so we must
   // create test threads before calling it.
@@ skipping 66 matching lines @@
   // arguments and switches in this function.)
   void ExpectExperimentalInvocation(
       const std::string& expected_suffix,
       const base::string16& expected_additional_argument) {
     EXPECT_EQ(default_version_, launched_version_);
     ASSERT_EQ(1U, launched_invocations_.size());
 
     const SwReporterInvocation& invocation = launched_invocations_.front();
     EXPECT_EQ(MakeTestFilePath(default_path_),
               invocation.command_line.GetProgram());
-    EXPECT_EQ(
-        40U,
-        invocation.command_line.GetSwitchValueASCII(kSessionIdSwitch).size());
-    EXPECT_EQ(kExperimentGroupName, invocation.command_line.GetSwitchValueASCII(
-                                        kEngineExperimentGroupSwitch));
+    EXPECT_EQ(40U, invocation.command_line
+                       .GetSwitchValueASCII(chrome_cleaner::kSessionIdSwitch)
+                       .size());
+    EXPECT_EQ(kExperimentGroupName,
+              invocation.command_line.GetSwitchValueASCII(
+                  chrome_cleaner::kEngineExperimentGroupSwitch));
 
     if (expected_suffix.empty()) {
       EXPECT_EQ(2U, invocation.command_line.GetSwitches().size());
       EXPECT_TRUE(invocation.suffix.empty());
     } else {
       EXPECT_EQ(3U, invocation.command_line.GetSwitches().size());
       EXPECT_EQ(expected_suffix, invocation.command_line.GetSwitchValueASCII(
-                                     kRegistrySuffixSwitch));
+                                     chrome_cleaner::kRegistrySuffixSwitch));
       EXPECT_EQ(expected_suffix, invocation.suffix);
     }
 
     if (expected_additional_argument.empty()) {
       EXPECT_TRUE(invocation.command_line.GetArgs().empty());
     } else {
       EXPECT_EQ(1U, invocation.command_line.GetArgs().size());
       EXPECT_EQ(expected_additional_argument,
                 invocation.command_line.GetArgs()[0]);
     }
@@ skipping 14 matching lines @@
     SwReporterInvocation invocation = launched_invocations_.front();
     launched_invocations_.pop();
     EXPECT_EQ(MakeTestFilePath(default_path_),
               invocation.command_line.GetProgram());
     // There should be one switch added from the manifest, plus registry-suffix
     // added automatically.
     EXPECT_EQ(4U, invocation.command_line.GetSwitches().size());
     EXPECT_EQ(expected_engine,
               invocation.command_line.GetSwitchValueASCII("engine"));
     EXPECT_EQ(expected_suffix, invocation.command_line.GetSwitchValueASCII(
-                                   kRegistrySuffixSwitch));
-    *out_session_id =
-        invocation.command_line.GetSwitchValueASCII(kSessionIdSwitch);
+                                   chrome_cleaner::kRegistrySuffixSwitch));
+    *out_session_id = invocation.command_line.GetSwitchValueASCII(
+        chrome_cleaner::kSessionIdSwitch);
     EXPECT_EQ(40U, out_session_id->size());
-    EXPECT_EQ(kExperimentGroupName, invocation.command_line.GetSwitchValueASCII(
-                                        kEngineExperimentGroupSwitch));
+    EXPECT_EQ(kExperimentGroupName,
+              invocation.command_line.GetSwitchValueASCII(
+                  chrome_cleaner::kEngineExperimentGroupSwitch));
     ASSERT_TRUE(invocation.command_line.GetArgs().empty());
     EXPECT_EQ(expected_suffix, invocation.suffix);
     EXPECT_EQ(expected_behaviours, invocation.supported_behaviours);
   }
 
   void ExpectLaunchError() {
     // The SwReporter should not be launched, and an error should be logged.
     EXPECT_TRUE(launched_invocations_.empty());
     histograms_.ExpectUniqueSample(kErrorHistogramName,
                                    SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS, 1);
@@ skipping 89 matching lines @@
   // The SwReporter should be launched once with the given arguments.
   EXPECT_EQ(default_version_, launched_version_);
   ASSERT_EQ(1U, launched_invocations_.size());
 
   const SwReporterInvocation& invocation = launched_invocations_.front();
   EXPECT_EQ(MakeTestFilePath(default_path_),
             invocation.command_line.GetProgram());
   EXPECT_EQ(4U, invocation.command_line.GetSwitches().size());
   EXPECT_EQ("experimental",
             invocation.command_line.GetSwitchValueASCII("engine"));
-  EXPECT_EQ("TestSuffix",
-            invocation.command_line.GetSwitchValueASCII(kRegistrySuffixSwitch));
-  EXPECT_EQ(
-      40U,
-      invocation.command_line.GetSwitchValueASCII(kSessionIdSwitch).size());
-  EXPECT_EQ(kExperimentGroupName, invocation.command_line.GetSwitchValueASCII(
-                                      kEngineExperimentGroupSwitch));
+  EXPECT_EQ("TestSuffix", invocation.command_line.GetSwitchValueASCII(
+                              chrome_cleaner::kRegistrySuffixSwitch));
+  EXPECT_EQ(40U, invocation.command_line
+                     .GetSwitchValueASCII(chrome_cleaner::kSessionIdSwitch)
+                     .size());
+  EXPECT_EQ(kExperimentGroupName,
+            invocation.command_line.GetSwitchValueASCII(
+                chrome_cleaner::kEngineExperimentGroupSwitch));
   ASSERT_EQ(1U, invocation.command_line.GetArgs().size());
   EXPECT_EQ(L"random argument", invocation.command_line.GetArgs()[0]);
   EXPECT_EQ("TestSuffix", invocation.suffix);
   EXPECT_EQ(0U, invocation.supported_behaviours);
   histograms_.ExpectTotalCount(kErrorHistogramName, 0);
 }
 
 TEST_F(ExperimentalSwReporterInstallerTest, MultipleInvocations) {
   SwReporterInstallerTraits traits(launched_callback_, true);
   CreateFeatureWithTag(kExperimentTag);
@@ skipping 373 matching lines @@
   traits.ComponentReady(
       default_version_, default_path_,
       base::DictionaryValue::From(base::JSONReader::Read(kTestManifest)));
 
   // The SwReporter should not be launched, and an error should be logged.
   EXPECT_TRUE(launched_invocations_.empty());
   histograms_.ExpectUniqueSample(kErrorHistogramName,
                                  SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS, 1);
 }
 }  // namespace component_updater