Fix LoggingTest.NestedLogAssertHandlers in official build.

Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG=713442
Review-Url: https://codereview.chromium.org/2831073002
Cr-Commit-Position: refs/heads/master@{#466051}
Committed: https://chromium.googlesource.com/chromium/src/+/4df548e4159bdcc2dcfe330eef756510ce45d0be

[Mark, 2017-04-20 15:46:29]

Description was changed from

==========
Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG=713442
==========

to

==========
Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG=713442
==========

[Mark, 2017-04-20 15:46:29]

mcolbert@chromium.org changed reviewers:
- mcolbert@chromium.org

[alex-ac, 2017-04-20 17:24:32]

alex-ac@yandex-team.ru changed reviewers:
+ thestig@chromium.org

[Nico, 2017-04-20 17:25:44]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-04-20 17:25:45]

lgtm

[Nico, 2017-04-20 17:25:48]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-04-20 17:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-04-20 17:28:38]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2017-04-20 17:28:39]

Can you edit the commit message to explain how this fixes the test, i.e. that
official builds discard the log string in CHECK()s?

https://codereview.chromium.org/2831073002/diff/1/base/logging_unittest.cc
File base/logging_unittest.cc (right):

https://codereview.chromium.org/2831073002/diff/1/base/logging_unittest.cc#ne...
base/logging_unittest.cc:522: _, _, base::StringPiece("First assert must be
catched by handler_a"),
Since you're changing this anyway, s/catched/caught/ here and below.

[Nico, 2017-04-20 17:31:44]

Let's land this to cure the bots first and do comments in a follow-up.

On Thu, Apr 20, 2017 at 1:28 PM, <hans@chromium.org> wrote:

> Can you edit the commit message to explain how this fixes the test, i.e.
> that
> official builds discard the log string in CHECK()s?
>
>
> https://codereview.chromium.org/2831073002/diff/1/base/logging_unittest.cc
> File base/logging_unittest.cc (right):
>
> https://codereview.chromium.org/2831073002/diff/1/base/
> logging_unittest.cc#newcode522
> base/logging_unittest.cc:522: _, _, base::StringPiece("First assert must
> be catched by handler_a"),
> Since you're changing this anyway, s/catched/caught/ here and below.
>
> https://codereview.chromium.org/2831073002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-04-20 17:42:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492709148920880, "parent_rev":
"439a48ad9710adb6dbf7c39e28d26f9e35d60be8", "commit_rev":
"4df548e4159bdcc2dcfe330eef756510ce45d0be"}

[commit-bot: I haz the power, 2017-04-20 17:42:57]

Description was changed from

==========
Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG=713442
==========

to

==========
Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG=713442

Review-Url: https://codereview.chromium.org/2831073002
Cr-Commit-Position: refs/heads/master@{#466051}
Committed:
https://chromium.googlesource.com/chromium/src/+/4df548e4159bdcc2dcfe330eef75...
==========

[commit-bot: I haz the power, 2017-04-20 17:42:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4df548e4159bdcc2dcfe330eef75...

[hans, 2017-04-20 17:56:36]

Follow-up: https://codereview.chromium.org/2827313003

On 2017/04/20 17:31:44, Nico wrote:
> Let's land this to cure the bots first and do comments in a follow-up.
> 
> On Thu, Apr 20, 2017 at 1:28 PM, <mailto:hans@chromium.org> wrote:
> 
> > Can you edit the commit message to explain how this fixes the test, i.e.
> > that
> > official builds discard the log string in CHECK()s?
> >
> >
> > https://codereview.chromium.org/2831073002/diff/1/base/logging_unittest.cc
> > File base/logging_unittest.cc (right):
> >
> > https://codereview.chromium.org/2831073002/diff/1/base/
> > logging_unittest.cc#newcode522
> > base/logging_unittest.cc:522: _, _, base::StringPiece("First assert must
> > be catched by handler_a"),
> > Since you're changing this anyway, s/catched/caught/ here and below.
> >
> > https://codereview.chromium.org/2831073002/