Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2827313003: Follow-up to LoggingTest.NestedLogAssertHandlers test fix in #466051 (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up to LoggingTest.NestedLogAssertHandlers test fix in #466051 s/catched/caught/ and add a comment on why LOG() is used rather than CHECK(). BUG=713442 Review-Url: https://codereview.chromium.org/2827313003 Cr-Commit-Position: refs/heads/master@{#466074} Committed: https://chromium.googlesource.com/chromium/src/+/297a914c51210df503dbdef10397d23604cd1270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M base/logging_unittest.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hans
ptal
3 years, 8 months ago (2017-04-20 17:56:10 UTC) #2
Nico
lgtm
3 years, 8 months ago (2017-04-20 17:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827313003/1
3 years, 8 months ago (2017-04-20 17:59:52 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 18:15:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/297a914c51210df503dbdef10397...

Powered by Google App Engine
This is Rietveld 408576698