Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2831053002:
webkit-layout-tests: Revert accidental addition of duplicate virtual tests (Closed)
Descriptionwebkit-layout-tests: Revert accidental addition of duplicate virtual tests
The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite
(patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )"
accidentally added the "external/wpt/css/CSS2/abspos" and
"external/wpt/css/CSS2/normal-flow" directory to the virtual suite
twice.
This causes layout tests on swarming to fail because the tests are then
run on two different shards making it impossible to merge the results.
This patch removes the second addition.
TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org,qyearsley@chromium.org,mcgreevy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635619, 713525
Review-Url: https://codereview.chromium.org/2831053002
Cr-Commit-Position: refs/heads/master@{#465920}
Committed: https://chromium.googlesource.com/chromium/src/+/1a802b27bf4b89e135972cb2e0dbb851524da9ef
Patch Set 1 #Patch Set 2 : webkit-layout-tests: Revert accidental addition of abspos twice. #Patch Set 3 : webkit-layout-tests: Revert accidental addition of abspos twice. #Messages
Total messages: 16 (12 generated)
Created Revert of Add wpt/css/CSS2/positioning LayoutNG virtual test suite.
Description was changed from ========== Revert of Add wpt/css/CSS2/positioning LayoutNG virtual test suite. (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ ) Reason for revert: Causes test to run on multiple shards. Original issue's description: > Add wpt/css/CSS2/positioning LayoutNG virtual test suite. > > BUG=635619 > > Review-Url: https://codereview.chromium.org/2823223004 > Cr-Commit-Position: refs/heads/master@{#465792} > Committed: https://chromium.googlesource.com/chromium/src/+/da81aa1de05ec039a032e824fa41... TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 ========== to ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/)" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 ==========
Description was changed from ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/)" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 ========== to ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 ==========
Description was changed from ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 ========== to ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ==========
Description was changed from ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ========== to ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ==========
tansell@chromium.org changed reviewers: + mcgreevy@chromium.org, qyearsley@chromium.org
Description was changed from ========== webkit-layout-tests: Revert accidental addition of abspos twice. The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" directory to the virtual suite twice. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ========== to ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ==========
Description was changed from ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ========== to ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ==========
Description was changed from ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org, qyearsley@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ========== to ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org,qyearsley... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ==========
mcgreevy@google.com changed reviewers: + mcgreevy@google.com
lgtm
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492670664956910,
"parent_rev": "7185f26bb323f0650f8831f6e2d2c976fd373e55", "commit_rev":
"1a802b27bf4b89e135972cb2e0dbb851524da9ef"}
Message was sent while issue was closed.
Description was changed from ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org,qyearsley... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 ========== to ========== webkit-layout-tests: Revert accidental addition of duplicate virtual tests The patch "Add wpt/css/CSS2/positioning LayoutNG virtual test suite (patchset #2 id:20001 of https://codereview.chromium.org/2823223004/ )" accidentally added the "external/wpt/css/CSS2/abspos" and "external/wpt/css/CSS2/normal-flow" directory to the virtual suite twice. This causes layout tests on swarming to fail because the tests are then run on two different shards making it impossible to merge the results. This patch removes the second addition. TBR=atotic@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org,qyearsley... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619,713525 Review-Url: https://codereview.chromium.org/2831053002 Cr-Commit-Position: refs/heads/master@{#465920} Committed: https://chromium.googlesource.com/chromium/src/+/1a802b27bf4b89e135972cb2e0db... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/chromium/src/+/1a802b27bf4b89e135972cb2e0db... |
