Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2823223004: Add wpt/css/CSS2/positioning LayoutNG virtual test suite. (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 8 months ago
Reviewers:
atotic, ikilpatrick
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add wpt/css/CSS2/positioning LayoutNG virtual test suite. BUG=635619 Review-Url: https://codereview.chromium.org/2823223004 Cr-Commit-Position: refs/heads/master@{#465792} Committed: https://chromium.googlesource.com/chromium/src/+/da81aa1de05ec039a032e824fa4174205308d58b

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +263 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/layout_ng/external/wpt/css/CSS2/positioning/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (13 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-18 23:04:48 UTC) #3
atotic
lgtm when done, can you email us the summary of all the new test suites ...
3 years, 8 months ago (2017-04-18 23:06:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823223004/20001
3 years, 8 months ago (2017-04-19 22:38:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/da81aa1de05ec039a032e824fa4174205308d58b
3 years, 8 months ago (2017-04-19 22:45:53 UTC) #17
mithro
3 years, 8 months ago (2017-04-20 05:38:37 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2831053002/ by tansell@chromium.org.

The reason for reverting is: Causes test to run on multiple shards..

Powered by Google App Engine
This is Rietveld 408576698