Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2830953004: Remove legacy codecs coverage from tough_video_cases pageset. (Closed)

Created:
3 years, 8 months ago by CalebRouleau
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy codecs coverage from tough_video_cases pageset. This reduces the number of pages from 38 to 27: 29% reduction. Hopefully that will reduce benchmark_duration a similar amount. BUG=710253 Review-Url: https://codereview.chromium.org/2830953004 Cr-Commit-Position: refs/heads/master@{#466156} Committed: https://chromium.googlesource.com/chromium/src/+/597f6ab23b8535ca35d128e25bb0f57398e6da37

Patch Set 1 #

Patch Set 2 : fix problems from merge. #

Patch Set 3 : re-add accidentally removed blank lines #

Patch Set 4 : revert theora filtering change. sorry John :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -187 lines) Patch
M tools/perf/benchmarks/media.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.py View 1 2 13 chunks +0 lines, -174 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/bear.webm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd.wav.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd1080.ogv.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd2160.mp4.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd2160.webm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd360.ogv.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd480.webm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd720.webm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/garden2_10s.ogv.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/tulip2.ogv.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/tulip2.webm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
nednguyen
lgtm
3 years, 8 months ago (2017-04-20 09:59:54 UTC) #3
johnchen
Please also undo my changes in https://codereview.chromium.org/2826293003, which are no longer necessary. LGTM otherwise.
3 years, 8 months ago (2017-04-20 18:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830953004/60001
3 years, 8 months ago (2017-04-20 20:46:47 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/597f6ab23b8535ca35d128e25bb0f57398e6da37
3 years, 8 months ago (2017-04-20 22:08:28 UTC) #10
DaleCurtis
Did you mean to drop 2160.mp4? I thought we were only dropping 4k vp8?
3 years, 8 months ago (2017-04-20 22:40:47 UTC) #12
CalebRouleau
3 years, 8 months ago (2017-04-20 23:44:47 UTC) #13
Message was sent while issue was closed.
On 2017/04/20 22:40:47, DaleCurtis wrote:
> Did you mean to drop 2160.mp4? I thought we were only dropping 4k vp8?

I left garden2_10s.mp4, which is also a ~4k mp4 aac h264 video.

Powered by Google App Engine
This is Rietveld 408576698