Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2826293003: Remove theora from Android media benchmarks (Closed)

Created:
3 years, 8 months ago by johnchen
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, CalebRouleau
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove theora from Android media benchmarks Some media benchmark pages use theora format, which isn't supported on Android. One of the media, tulip2.ogv was measured on Android and consumed lab resources while reporting meaningless data. This CL modifies media benchmarks to stop playing theora format media on Android. BUG=713113 Review-Url: https://codereview.chromium.org/2826293003 Cr-Commit-Position: refs/heads/master@{#465901} Committed: https://chromium.googlesource.com/chromium/src/+/5b42152cb32481bca8a330b023a1f2c57ad38cd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/media.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
johnchen
Caleb & Ned, This CL filters out a media that doesn't work on Android. PTAL. ...
3 years, 8 months ago (2017-04-19 22:03:57 UTC) #2
CalebRouleau
lgtm
3 years, 8 months ago (2017-04-19 22:06:04 UTC) #3
nednguyen
lgtm
3 years, 8 months ago (2017-04-20 03:48:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826293003/1
3 years, 8 months ago (2017-04-20 03:55:13 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 05:00:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b42152cb32481bca8a330b023a1...

Powered by Google App Engine
This is Rietveld 408576698