Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
index d66b67a895749d92f06cd713b45aa8d089e18ff1..45a275f0b79e6b95aee5eb6e81a2ebcadc6a0d06 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
@@ -123,7 +123,11 @@ public class SearchWidgetProvider extends AppWidgetProvider {
private static final Object DELEGATE_LOCK = new Object();
private static final Object OBSERVER_LOCK = new Object();
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("StaticFieldLeak")
private static SearchWidgetTemplateUrlServiceObserver sObserver;
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("StaticFieldLeak")
private static SearchWidgetProviderDelegate sDelegate;
/**
@@ -311,7 +315,9 @@ public class SearchWidgetProvider extends AppWidgetProvider {
}
/** Updates the number of consecutive crashes this widget has absorbed. */
- @SuppressLint("CommitPrefEdits")
+ @SuppressLint({
Ted C 2017/04/27 19:02:47 can this not all fit on a single line?
F 2017/04/28 18:25:15 Done.
+ "CommitPrefEdits", "ApplySharedPref"
+ })
static void updateNumConsecutiveCrashes(int newValue) {
SharedPreferences prefs = getDelegate().getSharedPreferences();
if (getNumConsecutiveCrashes(prefs) == newValue) return;

Powered by Google App Engine
This is Rietveld 408576698