chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabStateBrowserControlsVisibilityDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

index 28bffac403fbaac94651a152572f08b181df8cd0..37759d0133b5eb876598f54a226b1099cb07e04b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.services;

+import android.annotation.SuppressLint;

import android.content.Context;

import android.util.Log;

@@ -37,6 +38,8 @@ public class GoogleServicesManager implements ApplicationStateListener {

@VisibleForTesting

public static final String SESSION_TAG_PREFIX = "session_sync";

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("StaticFieldLeak")

private static GoogleServicesManager sGoogleServicesManager;

@VisibleForTesting