chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/PackageManagerDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

index 5fe5f3a82d483c1c09ae153a0268f0013570fbc0..2d112fe40f6ba447410f349bc967b0e641a21c16 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

@@ -73,7 +73,8 @@ public class ManageSpaceActivity extends AppCompatActivity implements View.OnCli

private boolean mIsNativeInitialized;

- @SuppressLint("CommitPrefEdits")

+ // TODO(crbug.com/635567): Fix this properly.

Ted C 2017/04/27 19:02:47 Remove, this is doing the right thing comments why

F 2017/04/28 18:25:15 Done.

+ @SuppressLint({"ApplySharedPref", "CommitPrefEdits"})

@Override

protected void onCreate(Bundle savedInstanceState) {

ensureActivityNotExported();