Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: base/android/java/src/org/chromium/base/ApplicationStatus.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/ApplicationStatus.java
diff --git a/base/android/java/src/org/chromium/base/ApplicationStatus.java b/base/android/java/src/org/chromium/base/ApplicationStatus.java
index 29b1029f88d286f5bdcb5f033c64d2f9497d454f..c0c8d263ddec510f102a50a53edc5e6577f5a1e9 100644
--- a/base/android/java/src/org/chromium/base/ApplicationStatus.java
+++ b/base/android/java/src/org/chromium/base/ApplicationStatus.java
@@ -61,6 +61,8 @@ public class ApplicationStatus {
private static Integer sCachedApplicationState;
/** Last activity that was shown (or null if none or it was destroyed). */
+ // TODO(crbug.com/635567): Fix this properly.
Ted C 2017/04/27 19:02:47 no fix needed, this is cleared when applicable alr
F 2017/04/28 18:25:14 Done.
+ @SuppressLint("StaticFieldLeak")
private static Activity sActivity;
/** A lazily initialized listener that forwards application state changes to native. */
@@ -357,6 +359,7 @@ public class ApplicationStatus {
* @param listener Listener to receive state changes.
* @param activity Activity to track or {@code null} to track all activities.
*/
+ // TODO(crbug.com/635567): Fix this properly.
Ted C 2017/04/27 19:02:47 fix what? activity.isDestroyed() is available in
F 2017/04/28 18:25:14 Done.
@SuppressLint("NewApi")
public static void registerStateListenerForActivity(ActivityStateListener listener,
Activity activity) {

Powered by Google App Engine
This is Rietveld 408576698