Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
index 8d955f015334403a99462f92ddbf812ab6ed23ab..1a6d436747ea2beb4ed6893800bc06f1be887fa7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser;
+import android.annotation.SuppressLint;
import android.app.Activity;
import android.app.Application;
import android.content.SharedPreferences;
@@ -43,6 +44,8 @@ public class ChromeActivitySessionTracker {
private static final String PREF_LOCALE = "locale";
+ // TODO(crbug.com/635567): Fix this properly.
Ted C 2017/04/27 19:02:47 Again, this is a leaky singleton intentionally So
F 2017/04/28 18:25:14 Done.
+ @SuppressLint("StaticFieldLeak")
private static ChromeActivitySessionTracker sInstance;
private final PowerBroadcastReceiver mPowerBroadcastReceiver = new PowerBroadcastReceiver();

Powered by Google App Engine
This is Rietveld 408576698