Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: build/android/lint/suppressions.xml

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 099410c1fe83cdd6421e99692d94bf70ad84fbfb..b08220bc77cbc388093d04f9384c5d5fece270ba 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -27,6 +27,9 @@ Still reading?
</issue>
<!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Asserts -->
<issue id="Assert" severity="ignore"/>
+ <issue id="AuthLeak" severity="Warning">
+ <ignore regexp="chrome/android/javatests"/>
+ </issue>
<issue id="BadHostnameVerifier" severity="Error">
<!-- Safe, used in test only. -->
<ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java"/>
@@ -37,6 +40,10 @@ Still reading?
<issue id="ButtonStyle" severity="Error">
<ignore regexp="remoting/android/host/res/layout/main.xml"/>
</issue>
+ <!-- Found in generated android_chrome_strings.xml. -->
+ <issue id="ByteOrderMark" severity="Error">
+ <ignore regexp="values-pt-rBR/android_chrome_strings.xml"/>
+ </issue>
<issue id="CommitPrefEdits">
<ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidChannelPreferences.java"/>
</issue>
@@ -53,7 +60,9 @@ Still reading?
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="Deprecated" severity="Error">
+ <ignore regexp="android:singleLine"/>
<ignore regexp="AndroidManifest.xml"/>
+ <ignore regexp="/test/"/>
</issue>
<issue id="DrawAllocation">
<ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
@@ -122,8 +131,6 @@ Still reading?
<ignore regexp="chromecast/internal"/>
<!-- It is OK for content_shell_apk to have missing assets. -->
<ignore regexp="content/shell/android/java/res/"/>
- <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
- <ignore regexp="remoting/android/java/res"/>
<!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png -->
<ignore regexp="res/drawable/icon.png"/>
</issue>
@@ -209,6 +216,8 @@ Still reading?
<ignore regexp="org/chromium/memconsumer/MemConsumer.*.class"/>
<ignore regexp="org/chromium/memconsumer/ResidentService.class"/>
<ignore regexp="org/chromium/mojo/bindings/ValidationTest.class"/>
+ <!-- TODO(crbug.com/635567): Fix this properly. -->
+ <ignore regexp="third_party/android_tools/sdk/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"/>
</issue>
<issue id="OldTargetApi">
<ignore path="AndroidManifest.xml"/>
@@ -446,6 +455,10 @@ Still reading?
<ignore regexp="media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java"/>
</issue>
<issue id="ViewConstructor" severity="ignore"/>
+ <issue id="VisibleForTests" severity="Warning">
+ <ignore regexp="chrome/android/javatests"/>
+ <ignore regexp="/test/"/>
+ </issue>
<issue id="WrongCall" severity="ignore"/>
<issue id="WrongConstant">
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java"/>

Powered by Google App Engine
This is Rietveld 408576698