Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2830753003: Evict "fallback" RawResource from MemoryCache (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Evict "fallback" RawResource from MemoryCache A service worker may ask the original renderer to re-fetch the request when a fetch-mode=CORS request was not handled. In most cases ResourceLoader restarts the resource, but in some cases it lets DocumentThreadableLoader handle the response. In such a case, we can see a Resource whose response's WasFallbackRequiredByServiceWorker is true. Previously ResourceFetcher::DetermineRevalidationPolicy forbade to reuse such a resource. This CL removes the logic. Instead, RawResource evicts itself when receiving such a response. BUG=652228 R=horo@chromium.org, tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2830753003 Cr-Commit-Position: refs/heads/master@{#465987} Committed: https://chromium.googlesource.com/chromium/src/+/5705c2783128e015cf8c9da3f7a1b188d81101b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
yhirano
3 years, 8 months ago (2017-04-20 08:27:49 UTC) #3
horo
lgtm
3 years, 8 months ago (2017-04-20 10:22:32 UTC) #6
tyoshino (SeeGerritForStatus)
CL description: Previsouly -> Previously
3 years, 8 months ago (2017-04-20 12:03:37 UTC) #7
yhirano
On 2017/04/20 12:03:37, tyoshino wrote: > CL description: Previsouly -> Previously Done.
3 years, 8 months ago (2017-04-20 12:05:00 UTC) #9
tyoshino (SeeGerritForStatus)
lgtm
3 years, 8 months ago (2017-04-20 12:14:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830753003/1
3 years, 8 months ago (2017-04-20 12:15:01 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 12:52:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5705c2783128e015cf8c9da3f7a1...

Powered by Google App Engine
This is Rietveld 408576698