Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2828243002:
Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy (Closed)
|
Created:
3 years, 8 months ago by yhirano Modified:
3 years, 8 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGive |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy
This CL changes DetermineRevalidationPolicy a bit to simplify it. With this
CL, |allow_stale_resources_| will be checked after
ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks
the synchronous policy and the cors policy, and neither of them is related
to staleness. Moreover, the synchronous policy was once checked BEFORE
allow_stale_resources_ (see [1]). Also, any user of
ResourceCacheValidationSuppressor, the class used to enable
|allow_stale_resource_|, doesn't seem to be interested in CORS. Hence I expect
no behavior change from this CL.
1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca
BUG=652228
R=hiroshige@chromium.org, japhet@chromium.org
Review-Url: https://codereview.chromium.org/2828243002
Cr-Commit-Position: refs/heads/master@{#466880}
Committed: https://chromium.googlesource.com/chromium/src/+/0b1688086e55683b586a5f00908266ea4e5a1296
Patch Set 1 #Patch Set 2 : rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 31 (23 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://codereview.chromium.org/2391523002 BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change with this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give allow_stale_resources_ a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, allow_stale_resources will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
s/cors the policy/cors policy/ in the description.
s/to interested/to be interested/
lgtm
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and cors the policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and the cors policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and the cors policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and the cors policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to be interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ==========
> s/cors the policy/cors policy/ in the description. > s/to interested/to be interested/ Done.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tyoshino@chromium.org Link to the patchset: https://codereview.chromium.org/2828243002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493081912660180,
"parent_rev": "e88b030f517ff578aff9af1a5a7762fc313163ad", "commit_rev":
"0b1688086e55683b586a5f00908266ea4e5a1296"}
Message was sent while issue was closed.
Description was changed from ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and the cors policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to be interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org ========== to ========== Give |allow_stale_resources_| a lower priority in DetermineRevalidationPolicy This CL changes DetermineRevalidationPolicy a bit to simplify it. With this CL, |allow_stale_resources_| will be checked after ResourceLoaderOptions::CanReuseRequest is checked. CanReuseRequest checks the synchronous policy and the cors policy, and neither of them is related to staleness. Moreover, the synchronous policy was once checked BEFORE allow_stale_resources_ (see [1]). Also, any user of ResourceCacheValidationSuppressor, the class used to enable |allow_stale_resource_|, doesn't seem to be interested in CORS. Hence I expect no behavior change from this CL. 1: https://crrev.com/733a476495c43c1f472e5770c9d8aeeb94c5caca BUG=652228 R=hiroshige@chromium.org, japhet@chromium.org Review-Url: https://codereview.chromium.org/2828243002 Cr-Commit-Position: refs/heads/master@{#466880} Committed: https://chromium.googlesource.com/chromium/src/+/0b1688086e55683b586a5f009082... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0b1688086e55683b586a5f009082... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
