Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2830733006:
win: Stop passing /wd4206 in PCH builds. (Closed)
Descriptionwin: Stop passing /wd4206 in PCH builds.
We already don't pass it for blink's PCHs and it seems to work fine there.
No intended behavior change, please revert if this breaks you.
BUG=none
Review-Url: https://codereview.chromium.org/2830733006
Cr-Commit-Position: refs/heads/master@{#467353}
Committed: https://chromium.googlesource.com/chromium/src/+/d7119231dcd23626b491d050706871c2729601a3
Patch Set 1 #
Messages
Total messages: 20 (14 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + sof@opera.com
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + sigbjornf@opera.com
sof: ping
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hans@chromium.org changed reviewers: + hans@chromium.org
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493225917138850, "parent_rev":
"2c33559b6bb6c8e574063e0f23520125f08bd393", "commit_rev":
"d7119231dcd23626b491d050706871c2729601a3"}
Message was sent while issue was closed.
Description was changed from ========== win: Stop passing /wd4206 in PCH builds. We already don't pass it for blink's PCHs and it seems to work fine there. No intended behavior change, please revert if this breaks you. BUG=none ========== to ========== win: Stop passing /wd4206 in PCH builds. We already don't pass it for blink's PCHs and it seems to work fine there. No intended behavior change, please revert if this breaks you. BUG=none Review-Url: https://codereview.chromium.org/2830733006 Cr-Commit-Position: refs/heads/master@{#467353} Committed: https://chromium.googlesource.com/chromium/src/+/d7119231dcd23626b491d0507068... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d7119231dcd23626b491d0507068...
Message was sent while issue was closed.
belated lgtm. (my apologies, focus elsewhere atm.) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
