Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: build/config/BUILD.gn

Issue 2830733006: win: Stop passing /wd4206 in PCH builds. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/features.gni") 10 import("//build/config/features.gni")
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 # source code in quotes for an #include directive. 352 # source code in quotes for an #include directive.
353 precompiled_header = "build/precompile.h" 353 precompiled_header = "build/precompile.h"
354 354
355 # This is a file that GN will compile with the above header. It will be 355 # This is a file that GN will compile with the above header. It will be
356 # implicitly added to the sources (potentially multiple times, with one 356 # implicitly added to the sources (potentially multiple times, with one
357 # variant for each language used in the target). 357 # variant for each language used in the target).
358 precompiled_source = "//build/precompile.cc" 358 precompiled_source = "//build/precompile.cc"
359 359
360 # Force include the header. 360 # Force include the header.
361 cflags = [ "/FI$precompiled_header" ] 361 cflags = [ "/FI$precompiled_header" ]
362
363 # Disable warning for "this file was empty after preprocessing". This
364 # error is generated only in C mode for ANSI compatibility. It conflicts
365 # with precompiled headers since the source file that's "compiled" for
366 # making the precompiled header is empty.
367 #
368 # This error doesn't happen every time. In VS2013, it seems if the .pch
369 # file doesn't exist, no error will be generated (probably MS tested this
370 # case but forgot the other one?). To reproduce this error, do a build,
371 # then delete the precompile.c.obj file, then build again.
372 #
373 # TODO(sof): determine VS2015 status and retire the setting from all
374 # precompiled configurations.
375 cflags_c = [ "/wd4206" ]
376 } else if (is_mac) { 362 } else if (is_mac) {
377 precompiled_source = "//build/precompile.h" 363 precompiled_source = "//build/precompile.h"
378 } 364 }
379 } 365 }
380 } 366 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698