Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Issue 2830653002: Media Controls: move volume slider to modules/. (Closed)
Patch Set: _ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
index b31c8faab967c0c281f1f35b1a003a6e333a1bea..a6289dbe9e516d390c539aa9ccc507d119752c04 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
@@ -62,6 +62,7 @@
#include "modules/media_controls/elements/MediaControlTextTrackListElement.h"
#include "modules/media_controls/elements/MediaControlTimelineElement.h"
#include "modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h"
+#include "modules/media_controls/elements/MediaControlVolumeSliderElement.h"
#include "platform/EventDispatchForbiddenScope.h"
namespace blink {
@@ -344,10 +345,8 @@ void MediaControlsImpl::InitializeControls() {
mute_button_ = new MediaControlMuteButtonElement(*this);
panel_->AppendChild(mute_button_);
- MediaControlVolumeSliderElement* slider =
- MediaControlVolumeSliderElement::Create(*this);
- volume_slider_ = slider;
- panel_->AppendChild(slider);
+ volume_slider_ = new MediaControlVolumeSliderElement(*this);
+ panel_->AppendChild(volume_slider_);
if (PreferHiddenVolumeControls(GetDocument()))
volume_slider_->SetIsWanted(false);

Powered by Google App Engine
This is Rietveld 408576698