Fix wrong viewport size on virtual keyboard IME change

Fix wrong viewport size on virtual keyboard IME change

On full width mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.

Review-Url: https://codereview.chromium.org/2830513002
Cr-Commit-Position: refs/heads/master@{#465648}
Committed: https://chromium.googlesource.com/chromium/src/+/1137b41f7fc845c2e7c6555c1d6dee6f75fa8236

[oka, 2017-04-18 22:57:53]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

on full with mode, the |requested_bounds| parameter passed to
SetChildBounds might have different offset from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Unless, wrong insets value is eventually set

BUG=
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

on full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets value is eventually set
in InitInsets for all overlapping aura windows.

BUG=709360
==========

[oka, 2017-04-18 23:03:31]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

on full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets value is eventually set
in InitInsets for all overlapping aura windows.

BUG=709360
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

on full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

[oka, 2017-04-18 23:03:49]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

on full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

On full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

[oka, 2017-04-18 23:06:10]

oka@chromium.org changed reviewers:
+ bshe@chromium.org

[oka, 2017-04-18 23:06:11]

bshe@ PTAL.

[oka, 2017-04-18 23:08:25]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

On full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

On full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

[oka, 2017-04-18 23:08:36]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 23:09:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 00:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:05:42]

Dry run: This issue passed the CQ dry run.

[bshe, 2017-04-19 13:44:45]

On 2017/04/18 23:06:11, oka wrote:
> bshe@ PTAL.

lgtm

[oka, 2017-04-19 17:10:03]

The CQ bit was checked by oka@chromium.org

[oka, 2017-04-19 17:10:19]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

On full with mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

On full width mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

[commit-bot: I haz the power, 2017-04-19 17:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:16:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492621803608510, "parent_rev":
"cdada755fecf17a13796dc49b7633c679cf7e84e", "commit_rev":
"1137b41f7fc845c2e7c6555c1d6dee6f75fa8236"}

[commit-bot: I haz the power, 2017-04-19 17:16:48]

Description was changed from

==========
Fix wrong viewport size on virtual keyboard IME change

On full width mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.
==========

to

==========
Fix wrong viewport size on virtual keyboard IME change

On full width mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.

Review-Url: https://codereview.chromium.org/2830513002
Cr-Commit-Position: refs/heads/master@{#465648}
Committed:
https://chromium.googlesource.com/chromium/src/+/1137b41f7fc845c2e7c6555c1d6d...
==========

[commit-bot: I haz the power, 2017-04-19 17:16:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1137b41f7fc845c2e7c6555c1d6d...