Issue 2824103005: Ensure caret in workarea after virtual keyboard IME change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824103005: Ensure caret in workarea after virtual keyboard IME change.

Created:
3 years, 8 months ago by oka

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, oka+watchvk_chromium.org, groby+virtualkb_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ensure caret in workarea after virtual keyboard IME change. Forces EnsureCarentInWorkArea to be called on IME changes by making NotifyKeyboardBoundsChanging call EnsureCarentInWorkArea. On IME change, SetChildBounds sets the virtual keyboard container size and calls NotifyKeyboardBoundsChanging, but EnsureCaretInWorkArea was not called. BUG=709360 TEST=manually tested the bug is resolved.

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/keyboard/keyboard_controller.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2830513002 Patch 1

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

oka

The CQ bit was checked by oka@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-04-19 00:11:30 UTC) #1

oka

The CQ bit was checked by oka@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-04-19 00:11:36 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824103005/1

3 years, 8 months ago (2017-04-19 00:12:16 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-04-19 00:56:24 UTC) #4

commit-bot: I haz the power

3 years, 8 months ago (2017-04-19 00:56:25 UTC) #5

Dry run: This issue passed the CQ dry run.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages