Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2830413002: Add Incognito Navigation histograms (Closed)

Created:
3 years, 8 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add Incognito Navigation histograms As a part of scoping changes to behavior, we want to collect the absolute number of page navigations in Incognito mode. BUG=712843 TEST=components_unittests --gtest_filter=NavigationMetrics*.* Review-Url: https://codereview.chromium.org/2827983003 Cr-Commit-Position: refs/heads/master@{#466140} (cherry picked from commit 16908bf6ea4341513c47b4c861a2408c55941a30) Review-Url: https://codereview.chromium.org/2830413002 . Cr-Commit-Position: refs/branch-heads/3071@{#131} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/22ae1aa67a701300ac2714312fc2d5319cf84247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M components/navigation_metrics/navigation_metrics.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M components/navigation_metrics/navigation_metrics_unittest.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
elawrence
3 years, 8 months ago (2017-04-21 22:05:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22ae1aa67a701300ac2714312fc2d5319cf84247.

Powered by Google App Engine
This is Rietveld 408576698