Issue 2830413002: Add Incognito Navigation histograms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2830413002: Add Incognito Navigation histograms (Closed)

Created:
3 years, 8 months ago by elawrence

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Add Incognito Navigation histograms As a part of scoping changes to behavior, we want to collect the absolute number of page navigations in Incognito mode. BUG=712843 TEST=components_unittests --gtest_filter=NavigationMetrics*.* Review-Url: https://codereview.chromium.org/2827983003 Cr-Commit-Position: refs/heads/master@{#466140} (cherry picked from commit 16908bf6ea4341513c47b4c861a2408c55941a30) Review-Url: https://codereview.chromium.org/2830413002 . Cr-Commit-Position: refs/branch-heads/3071@{#131} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/22ae1aa67a701300ac2714312fc2d5319cf84247

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -4 lines)			Patch
M	components/navigation_metrics/navigation_metrics.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	components/navigation_metrics/navigation_metrics_unittest.cc	View	3 chunks	+35 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	3 chunks	+23 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

elawrence

3 years, 8 months ago (2017-04-21 22:05:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
22ae1aa67a701300ac2714312fc2d5319cf84247.