Add Incognito Navigation histograms

Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2827983003
Cr-Commit-Position: refs/heads/master@{#466140}
Committed: https://chromium.googlesource.com/chromium/src/+/16908bf6ea4341513c47b4c861a2408c55941a30

[elawrence, 2017-04-19 22:12:45]

elawrence@chromium.org changed reviewers:
+ davidben@chromium.org, mpearson@chromium.org

[elawrence, 2017-04-19 22:12:45]

This is the other half of the Incognito navigation metrics change; it introduces
two new metrics that count navigations while in off-the-record mode.
 
mpearson@ PTAL at histograms.xml
davidben@ PTAL at components/navigation_metrics/*

[elawrence, 2017-04-19 22:13:02]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:13:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-04-19 22:45:46]

generally fine, with one comment here, and one OTR comment I sent via e-mail :-)

--mark

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31593: +    history.pushState are
excluded.
Are they included in the one below?

(If yes, no change is necessary.)

[elawrence, 2017-04-19 22:55:13]

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31593: +    history.pushState are
excluded.
On 2017/04/19 22:45:45, Mark P wrote:
> Are they included in the one below?
> 
> (If yes, no change is necessary.)

Yes. The difference between MainFrameSchemeDifferentPage*{OTR} and
MainFrameScheme{OTR} is that the "DifferentPage" version of the metric is only
recorded if the navigation goes to a different page; that is to say, when it is
NOT a fragment change or history.pushState.

By subtracting MainFrameSchemeDifferentPage from MainFrameScheme, one could
calculate the number of intra-page navigations.

[msramek, 2017-04-20 09:59:28]

msramek@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2017-04-20 09:59:29]

LGTM from privacy side.

Incognito-specific metrics have been recently explicitly allowed, since we
consider UMA to be sufficiently privacy preserving for that not to be a problem.

I don't see any issue with the change from unique origins to total count either.

[Mark P, 2017-04-20 18:56:43]

histograms.xml lgtm

[davidben, 2017-04-20 19:26:28]

lgtm

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31589: + 
<owner>davidben@chromium.org</owner>
Should you all be owning these histograms? It seems you're the main users of
these anyway. Chris and I just took ownership of the old ones because they were
unowned.

[elawrence, 2017-04-20 19:51:01]

On 2017/04/20 19:26:28, davidben wrote:
> lgtm
> 
>
https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2827983003/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:31589: + 
> <mailto:owner>davidben@chromium.org</owner>
> Should you all be owning these histograms? It seems you're the main users of
> these anyway. Chris and I just took ownership of the old ones because they
were
> unowned.

Thanks, we've taken ownership of the Navigation.MainFrame* histograms.

[elawrence, 2017-04-20 19:51:06]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-04-20 19:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, mpearson@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2827983003/#ps40001
(title: "Update histogram owners")

[davidben, 2017-04-20 19:51:43]

lgtm

[commit-bot: I haz the power, 2017-04-20 19:51:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:26:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492717866514800,
"parent_rev": "5c129fa2384499f365d593c3cb23a3921c98a845", "commit_rev":
"16908bf6ea4341513c47b4c861a2408c55941a30"}

[commit-bot: I haz the power, 2017-04-20 21:27:06]

Description was changed from

==========
Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

to

==========
Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2827983003
Cr-Commit-Position: refs/heads/master@{#466140}
Committed:
https://chromium.googlesource.com/chromium/src/+/16908bf6ea4341513c47b4c861a2...
==========

[commit-bot: I haz the power, 2017-04-20 21:27:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/16908bf6ea4341513c47b4c861a2...