Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2830213002: [DMC #1.911] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by rlanday
Modified:
4 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange() yosin pointed out that it's confusing to have so many methods named RemoveMarkers(): https://codereview.chromium.org/2820633002#msg30 This is the first of several renaming CLs I'm going to upload BUG=707867 Review-Url: https://codereview.chromium.org/2830213002 Cr-Commit-Position: refs/heads/master@{#466302} Committed: https://chromium.googlesource.com/chromium/src/+/27f9eb47ba02349a8b5e850c597d4778b6c38846

Patch Set 1 #

Patch Set 2 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 20 (11 generated)
rlanday
4 months ago (2017-04-21 03:32:27 UTC) #2
Xiaocheng
lgtm. This patch doesn't seem to depend on any other patch. You may remove the ...
4 months ago (2017-04-21 04:17:12 UTC) #5
Xiaocheng
Btw, it's OK to combine a few trivial changes (like function renaming) in one patch, ...
4 months ago (2017-04-21 04:20:36 UTC) #6
rlanday
Yep, 1.911 through 1.915 are all independent. I need them stacked up linearly in my ...
4 months ago (2017-04-21 04:57:30 UTC) #7
Xiaocheng
On 2017/04/21 at 04:57:30, rlanday wrote: > Yep, 1.911 through 1.915 are all independent. I ...
4 months ago (2017-04-21 05:14:23 UTC) #8
yosin_UTC9
lgtm
4 months ago (2017-04-21 08:18:11 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2830033002 Patch 1). Please resolve the dependency and ...
4 months ago (2017-04-21 08:18:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830213002/20001
4 months ago (2017-04-21 08:23:52 UTC) #17
commit-bot: I haz the power
4 months ago (2017-04-21 10:22:28 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27f9eb47ba02349a8b5e850c597d...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b