[DMC #1.911] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange()

Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the first of several renaming CLs I'm going to upload

BUG=707867
Review-Url: https://codereview.chromium.org/2830213002
Cr-Commit-Position: refs/heads/master@{#466302}
Committed: https://chromium.googlesource.com/chromium/src/+/27f9eb47ba02349a8b5e850c597d4778b6c38846

[rlanday, 2017-04-21 03:27:09]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-04-21 03:34:09]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 03:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-21 04:17:12]

lgtm.

This patch doesn't seem to depend on any other patch. You may remove the
dependency for faster iteration.

[Xiaocheng, 2017-04-21 04:20:36]

Btw, it's OK to combine a few trivial changes (like function renaming) in one
patch, since in most cases, such a patch is correct as long as it passes
compilation.

[rlanday, 2017-04-21 04:57:30]

Yep, 1.911 through 1.915 are all independent. I need them stacked up linearly in
my local repo so I can work on top of them, but they can be landed in any order.

I decided to split up the patches because some of the renamings require touching
files we'll need a non-editing OWNER to approve, and I didn't want those patches
to be too large.

[Xiaocheng, 2017-04-21 05:14:23]

On 2017/04/21 at 04:57:30, rlanday wrote:
> Yep, 1.911 through 1.915 are all independent. I need them stacked up linearly
in
> my local repo so I can work on top of them, but they can be landed in any
order.
> 
> I decided to split up the patches because some of the renamings require
touching
> files we'll need a non-editing OWNER to approve, and I didn't want those
patches
> to be too large.

OK, it's a reasonable plan.

Please notify yosin@ so that he reviews all of them together.

[commit-bot: I haz the power, 2017-04-21 06:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 06:33:05]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-21 08:18:10]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-21 08:18:11]

lgtm

[commit-bot: I haz the power, 2017-04-21 08:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 08:18:20]

This CL has an open dependency (Issue 2830033002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rlanday, 2017-04-21 08:23:41]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-21 08:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2830213002/#ps20001
(title: "Remove dependency")

[commit-bot: I haz the power, 2017-04-21 08:23:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 10:22:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492763021979380,
"parent_rev": "34a8c858b449645cfc17fa29d920ce21485f98ad", "commit_rev":
"27f9eb47ba02349a8b5e850c597d4778b6c38846"}

[commit-bot: I haz the power, 2017-04-21 10:22:27]

Description was changed from

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the first of several renaming CLs I'm going to upload

BUG=707867
==========

to

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the first of several renaming CLs I'm going to upload

BUG=707867

Review-Url: https://codereview.chromium.org/2830213002
Cr-Commit-Position: refs/heads/master@{#466302}
Committed:
https://chromium.googlesource.com/chromium/src/+/27f9eb47ba02349a8b5e850c597d...
==========

[commit-bot: I haz the power, 2017-04-21 10:22:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27f9eb47ba02349a8b5e850c597d...