third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2830213002: [DMC #1.911] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2830213002: [DMC #1.911] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInRange() (Closed)

Patch Set: Remove dependency Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 7b6148b6ed0926998089a8ff1af34c8d4c89c43b..9d4938fb2e322fedf808c9e3e3132150766f5e09 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -278,8 +278,8 @@ TEST_F(DocumentMarkerControllerTest, RemoveStartOfMarker) {

// Remove markers that overlap "a"

marker_range = EphemeralRange(Position(text, 0), Position(text, 1));

- GetDocument().Markers().RemoveMarkers(marker_range,

- DocumentMarker::AllMarkers());

+ GetDocument().Markers().RemoveMarkersInRange(marker_range,

+ DocumentMarker::AllMarkers());

EXPECT_EQ(0u, MarkerController().Markers().size());

}

@@ -298,8 +298,8 @@ TEST_F(DocumentMarkerControllerTest, RemoveMiddleOfMarker) {

// Remove markers that overlap "b"

marker_range = EphemeralRange(Position(text, 1), Position(text, 2));

- GetDocument().Markers().RemoveMarkers(marker_range,

- DocumentMarker::AllMarkers());

+ GetDocument().Markers().RemoveMarkersInRange(marker_range,

+ DocumentMarker::AllMarkers());

EXPECT_EQ(0u, MarkerController().Markers().size());

}

@@ -318,8 +318,8 @@ TEST_F(DocumentMarkerControllerTest, RemoveEndOfMarker) {

// Remove markers that overlap "c"

marker_range = EphemeralRange(Position(text, 2), Position(text, 3));

- GetDocument().Markers().RemoveMarkers(marker_range,

- DocumentMarker::AllMarkers());

+ GetDocument().Markers().RemoveMarkersInRange(marker_range,

+ DocumentMarker::AllMarkers());

EXPECT_EQ(0u, MarkerController().Markers().size());

}