Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2830163002: Adjust overlay scrollbar appearance. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Adjust overlay scrollbar appearance. - share more constants between Blink and native (Views) - make Views paint a 1px stroke instead of a 1dip stroke, and update constants as per latest spec. - fix a bug with Blink overlay scrollbars where stroke was painted on all sides instead of just three sides. BUG=710550 Review-Url: https://codereview.chromium.org/2818033002 Cr-Commit-Position: refs/heads/master@{#465319} (cherry picked from commit 41aea3751213e055f31f13d449bf21518432c6cf) Review-Url: https://codereview.chromium.org/2830163002 . Cr-Commit-Position: refs/branch-heads/3071@{#104} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/fa5b15157ef0dee2e2969115095a1a97bf0323d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M ui/native_theme/native_theme_aura.cc View 5 chunks +17 lines, -26 lines 0 comments Download
M ui/native_theme/overlay_scrollbar_constants_aura.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 6 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
3 years, 8 months ago (2017-04-20 22:52:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa5b15157ef0dee2e2969115095a1a97bf0323d4.

Powered by Google App Engine
This is Rietveld 408576698