Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2818033002: Adjust overlay scrollbar appearance. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
bokan, sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust overlay scrollbar appearance. - share more constants between Blink and native (Views) - make Views paint a 1px stroke instead of a 1dip stroke, and update constants as per latest spec. - fix a bug with Blink overlay scrollbars where stroke was painted on all sides instead of just three sides. BUG=710550 Review-Url: https://codereview.chromium.org/2818033002 Cr-Commit-Position: refs/heads/master@{#465319} Committed: https://chromium.googlesource.com/chromium/src/+/41aea3751213e055f31f13d449bf21518432c6cf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M ui/native_theme/native_theme_aura.cc View 5 chunks +17 lines, -26 lines 2 comments Download
M ui/native_theme/overlay_scrollbar_constants_aura.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 6 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Evan Stade
+bokan ptal at NativeThemeAura changes +sadrul please review
3 years, 8 months ago (2017-04-14 16:48:43 UTC) #6
Evan Stade
On 2017/04/14 16:48:43, Evan Stade wrote: > +bokan ptal at NativeThemeAura changes > +sadrul please ...
3 years, 8 months ago (2017-04-17 19:48:51 UTC) #7
bokan
Sorry for the delay, Canada's been off for Easter a few days. https://codereview.chromium.org/2818033002/diff/1/ui/native_theme/native_theme_aura.cc File ui/native_theme/native_theme_aura.cc ...
3 years, 8 months ago (2017-04-18 13:17:56 UTC) #8
Evan Stade
https://codereview.chromium.org/2818033002/diff/1/ui/native_theme/native_theme_aura.cc File ui/native_theme/native_theme_aura.cc (right): https://codereview.chromium.org/2818033002/diff/1/ui/native_theme/native_theme_aura.cc#newcode248 ui/native_theme/native_theme_aura.cc:248: stroke_rect.Inset(stroke_insets + edge_adjust_insets); On 2017/04/18 13:17:56, bokan wrote: > ...
3 years, 8 months ago (2017-04-18 14:13:31 UTC) #9
bokan
On 2017/04/18 14:13:31, Evan Stade wrote: > https://codereview.chromium.org/2818033002/diff/1/ui/native_theme/native_theme_aura.cc > File ui/native_theme/native_theme_aura.cc (right): > > https://codereview.chromium.org/2818033002/diff/1/ui/native_theme/native_theme_aura.cc#newcode248 ...
3 years, 8 months ago (2017-04-18 14:28:40 UTC) #10
sadrul
lgtm
3 years, 8 months ago (2017-04-18 17:32:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818033002/1
3 years, 8 months ago (2017-04-18 18:21:49 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:17:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41aea3751213e055f31f13d449bf...

Powered by Google App Engine
This is Rietveld 408576698