Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2830033002: [DMC #1.91] Rewrite loops in DocumentMarkerController to use ListForType() (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite loops in DocumentMarkerController to use ListForType() xiaochengh pointed out in another code review that this method is not being used consistently: https://codereview.chromium.org/2820633002#msg26 After this CL, it will be used consistently. BUG=707867 Review-Url: https://codereview.chromium.org/2830033002 Cr-Commit-Position: refs/heads/master@{#466290} Committed: https://chromium.googlesource.com/chromium/src/+/2d9f45d2abbc726557c6f00ba76e6128c478416e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 10 chunks +27 lines, -47 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
rlanday
3 years, 8 months ago (2017-04-20 10:12:04 UTC) #4
Xiaocheng
lgtm
3 years, 8 months ago (2017-04-20 10:16:33 UTC) #5
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-21 08:21:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830033002/1
3 years, 8 months ago (2017-04-21 08:44:26 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 08:48:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d9f45d2abbc726557c6f00ba76e...

Powered by Google App Engine
This is Rietveld 408576698