DevTools: Base aggregated tree view percentage on the busy time.

DevTools: Base aggregated tree view percentage on the busy time.

Previously these included idle time.

BUG=713398
Review-Url: https://codereview.chromium.org/2829923002
Cr-Commit-Position: refs/heads/master@{#467203}
Committed: https://chromium.googlesource.com/chromium/src/+/0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9

[alph, 2017-04-20 00:43:28]

alph@chromium.org changed reviewers:
+ paulirish@chromium.org, pfeldman@chromium.org

[alph, 2017-04-21 20:05:06]

Gentle ping

[pfeldman, 2017-04-21 20:10:09]

https://codereview.chromium.org/2829923002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
(right):

https://codereview.chromium.org/2829923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:253:
this.selfTime -= Array.from(flatNodes.values()).reduce((acc, node) => acc +
node.totalTime, 0);
Are you implementing this?

for (var node of flatNodes.values())
  this.selfTime -= node.totalTime;

[alph, 2017-04-21 20:20:00]

https://codereview.chromium.org/2829923002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
(right):

https://codereview.chromium.org/2829923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:253:
this.selfTime -= Array.from(flatNodes.values()).reduce((acc, node) => acc +
node.totalTime, 0);
On 2017/04/21 20:10:09, pfeldman wrote:
> Are you implementing this?
> 
> for (var node of flatNodes.values())
>   this.selfTime -= node.totalTime;

Done.

[alph, 2017-04-25 20:50:03]

gentle ping

[pfeldman, 2017-04-25 21:06:50]

lgtm

[alph, 2017-04-25 21:09:48]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:10:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:34:19]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alph, 2017-04-26 00:15:04]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:15:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:04:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493165704475230,
"parent_rev": "3a0fdce4d4151a52fdfc3c67870887f25eb68ee9", "commit_rev":
"0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9"}

[commit-bot: I haz the power, 2017-04-26 02:05:09]

Description was changed from

==========
DevTools: Base aggregated tree view percentage on the busy time.

Previously these included idle time.

BUG=713398
==========

to

==========
DevTools: Base aggregated tree view percentage on the busy time.

Previously these included idle time.

BUG=713398

Review-Url: https://codereview.chromium.org/2829923002
Cr-Commit-Position: refs/heads/master@{#467203}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d132efa7a0e1579c81f3eb89eeb...
==========

[commit-bot: I haz the power, 2017-04-26 02:05:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d132efa7a0e1579c81f3eb89eeb...