Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2829923002: DevTools: Base aggregated tree view percentage on the busy time. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 37e7ff121ec87cb141a3fbfb1ac9558ae2a4e757..91b451d7622f237cf1c14832ba5f1de4f7fbf357 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -249,14 +249,14 @@ Timeline.TimelineTreeView = class extends UI.VBox {
var children = this._root.children();
var maxSelfTime = 0;
var maxTotalTime = 0;
+ var totalUsedTime = this._root.totalTime - this._root.selfTime;
for (var child of children.values()) {
maxSelfTime = Math.max(maxSelfTime, child.selfTime);
maxTotalTime = Math.max(maxTotalTime, child.totalTime);
}
for (var child of children.values()) {
// Exclude the idle time off the total calculation.
- var gridNode =
- new Timeline.TimelineTreeView.TreeGridNode(child, this._root.totalTime, maxSelfTime, maxTotalTime, this);
+ var gridNode = new Timeline.TimelineTreeView.TreeGridNode(child, totalUsedTime, maxSelfTime, maxTotalTime, this);
this._dataGrid.insertChild(gridNode);
}
this._sortingChanged();
@@ -844,6 +844,7 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
return null;
}
}
+
/**
* @override
* @param {!UI.ContextMenu} contextMenu
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698