Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2829853009: cc : Add DCHECKs to ensure we have valid proprety tree indices at commit (Closed)

Created:
3 years, 8 months ago by jaydasika
Modified:
3 years, 8 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, pdr., trchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Add DCHECKs to ensure we have valid proprety tree indices at commit There has been a spike in crash reports because of invalid proeprty tree indices recently(crbug.com/712586, crbug.com/708951). This CL adds some DCHECKs for sanity checking. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2829853009 Cr-Commit-Position: refs/heads/master@{#467204} Committed: https://chromium.googlesource.com/chromium/src/+/31790e2307fbd3316eb723a97470b913e15557c2

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix test failures #

Patch Set 3 : test failure and comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 10 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (22 generated)
jaydasika
PTAL
3 years, 8 months ago (2017-04-21 22:19:07 UTC) #5
enne (OOO)
I'm guessing that all these test changes are to satisfy the new DCHECKs? If so, ...
3 years, 8 months ago (2017-04-21 22:57:28 UTC) #10
jaydasika
Yes, all the test changes are to ensure the new DCHECKs pass. https://codereview.chromium.org/2829853009/diff/1/cc/trees/tree_synchronizer.cc File cc/trees/tree_synchronizer.cc ...
3 years, 8 months ago (2017-04-25 21:02:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829853009/40001
3 years, 8 months ago (2017-04-26 02:03:38 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 02:09:41 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31790e2307fbd3316eb723a97470...

Powered by Google App Engine
This is Rietveld 408576698