cc : Add DCHECKs to ensure we have valid proprety tree indices at commit

cc/trees/tree_synchronizer.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/tree_synchronizer.h"
 
 #include <stddef.h>
 
 #include <set>
 
@@ skipping 56 matching lines @@
                                                   LayerType* layer,
                                                   LayerTreeImpl* tree_impl) {
   if (!layer)
     return nullptr;
   std::unique_ptr<LayerImpl> layer_impl = std::move((*old_layers)[layer->id()]);
   if (!layer_impl)
     layer_impl = layer->CreateLayerImpl(tree_impl);
   return layer_impl;
 }
 
+#if DCHECK_IS_ON()
+template <typename LayerType>
+static bool LayerHasValidPropertyTreeIndices(LayerType* layer) {
+  DCHECK(layer);
+  return layer->transform_tree_index() != TransformTree::kInvalidNodeId &&

[enne (OOO), 2017/04/21 22:57:28]

One thing you might consider is to just make this function void
AssertValidPropertyTreeIndices (with an empty body for !DCHECK_IS_ON, and then
you can assert each of these individually, which might make tracking down a
failure easier.

[jaydasika, 2017/04/25 21:02:38]

Added AssertValidPropertyTreeIndices (we still need
LayerHasValidPropertyTreeIndices also), made sure these functions are only
called when DCHECK_IS_ON = true.

+         layer->effect_tree_index() != EffectTree::kInvalidNodeId &&
+         layer->clip_tree_index() != ClipTree::kInvalidNodeId &&
+         layer->scroll_tree_index() != ScrollTree::kInvalidNodeId;
+}
+#endif
+
 template <typename LayerTreeType>
 void PushLayerList(OwnedLayerImplMap* old_layers,
                    LayerTreeType* host,
                    LayerTreeImpl* tree_impl) {
   tree_impl->ClearLayerList();
   for (auto* layer : *host) {
     std::unique_ptr<LayerImpl> layer_impl(
         ReuseOrCreateLayerImpl(old_layers, layer, tree_impl));
 
+    // Every layer should have valid property tree indices
+    DCHECK(LayerHasValidPropertyTreeIndices(layer));
+    // Every layer_impl should either have valid property tree indices already
+    // or the corresponding layer should push them onto layer_impl.
+    DCHECK(LayerHasValidPropertyTreeIndices(layer_impl.get()) ||
+           host->LayerNeedsPushPropertiesForTesting(layer));
     tree_impl->AddToLayerList(layer_impl.get());
     tree_impl->AddLayer(std::move(layer_impl));
   }
   tree_impl->OnCanDrawStateChangedForTree();
 }
 
 template <typename LayerType>
 static void PushLayerPropertiesInternal(
     std::unordered_set<LayerType*> layers_that_should_push_properties,
     LayerTreeImpl* impl_tree) {
@@ skipping 10 matching lines @@
                               active_tree);
 }
 
 void TreeSynchronizer::PushLayerProperties(LayerTreeHost* host_tree,
                                            LayerTreeImpl* impl_tree) {
   PushLayerPropertiesInternal(host_tree->LayersThatShouldPushProperties(),
                               impl_tree);
 }
 
 }  // namespace cc