Issue 2829833005: [i18n] unit test for commas in Polymer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829833005: [i18n] unit test for commas in Polymer (Closed)

Created:
3 years, 8 months ago by dschuyler

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

[i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=705850 Review-Url: https://codereview.chromium.org/2814273005 Cr-Commit-Position: refs/heads/master@{#464794} (cherry picked from commit 8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0) Review-Url: https://codereview.chromium.org/2829833005 . Cr-Commit-Position: refs/branch-heads/3071@{#93} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d70d39e251a031a5a0daa70445d3f78ff704b355

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	ui/base/template_expressions_unittest.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

dschuyler

3 years, 8 months ago (2017-04-20 18:40:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d70d39e251a031a5a0daa70445d3f78ff704b355.