Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2814273005:
[i18n] unit test for commas in Polymer (Closed)
Description[i18n] unit test for commas in Polymer
This adds unit test for escaping commas in Polymer strings.
Related to https://codereview.chromium.org/2818053002/
BUG=705850
Review-Url: https://codereview.chromium.org/2814273005
Cr-Commit-Position: refs/heads/master@{#464794}
Committed: https://chromium.googlesource.com/chromium/src/+/8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0
Patch Set 1 : cleanup #Patch Set 2 : merge #
Messages
Total messages: 30 (25 generated)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. BUG=None ========== to ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=None ==========
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/14 at 01:22:36, dschuyler wrote: > LGTM. Also optional nit: I suggest linking the original bug 705850 to this CL instead of "BUG=None". So that - Someone reading crbug.com/705850 in the future can easily conclude that a test was added - Someone looking at this CL in the future can easily figure out what was the bug that is covered by this test.
Description was changed from ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=None ========== to ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=705850 ==========
The CQ bit was checked by dschuyler@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2818053002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by dschuyler@chromium.org
The CQ bit was unchecked by dschuyler@chromium.org
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2814273005/#ps60001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492203827838970,
"parent_rev": "8fb018ae054fc1c71b3887ca3bbba245e4a9db52", "commit_rev":
"8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0"}
Message was sent while issue was closed.
Description was changed from ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=705850 ========== to ========== [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG=705850 Review-Url: https://codereview.chromium.org/2814273005 Cr-Commit-Position: refs/heads/master@{#464794} Committed: https://chromium.googlesource.com/chromium/src/+/8b6a1ef9682320bdfc2bf9a604ec... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/8b6a1ef9682320bdfc2bf9a604ec... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
