Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2829673002: Don't update descendant visual rects on border radius change (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't update descendant visual rects on border radius change Border radius doesn't affect descendants' visual rects. This fixes the "Check failed: parent_context.tree_builder_context-> is_actually_needed" failure when running tools/perf/run_benchmark run rasterize_and_record_micro.top_25 --browser=debug --story-filter=plus The failure was because the subtree was marked to update visual rects but ancestors didn't update paint properties. BUG=710665 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2821183002 Cr-Commit-Position: refs/heads/master@{#465093} TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2829673002 Cr-Commit-Position: refs/branch-heads/3071@{#50} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/083dce500b259c3b8ff3c9d3bf641f42bf37fa37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -42 lines) Patch
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 4 chunks +43 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829673002/1
3 years, 8 months ago (2017-04-19 15:50:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:51:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/083dce500b259c3b8ff3c9d3bf64...

Powered by Google App Engine
This is Rietveld 408576698