Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2829653003: PROTOTYPE (incomplete): Add quad renderer and stub bits to handle security warnings. (Closed)

Created:
3 years, 8 months ago by cjgrant
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PROTOTYPE (incomplete): Add quad renderer and stub bits to handle security warnings. BUG=

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -13 lines) Patch
A chrome/browser/android/vr_shell/textured_element.h View 1 chunk +31 lines, -0 lines 1 comment Download
A chrome/browser/android/vr_shell/textured_element.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_element.h View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_element.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 2 chunks +27 lines, -0 lines 3 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +8 lines, -0 lines 1 comment Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +6 lines, -7 lines 1 comment Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.cc View 3 chunks +84 lines, -0 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 1 (0 generated)
cjgrant
3 years, 8 months ago (2017-04-19 16:24:53 UTC) #1
https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textured_element.h (right):

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textured_element.h:24: // SkBitmap bitmap_;
Either this class, or UITexture itself, should handle the allocation of a GL
texture ID and an SkSurface, I think.  Scene Manager doesn't care, and the
common rendering code should not know about element details.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager.cc:17: class SecurityWarning :
public TexturedElement {
Temporary home - these shouldn't be in this file.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager.cc:24: //texture_->Draw();
I figure drawing the one-off textures in the constructor is okay.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager.cc:36: //unsigned int
texture_id_;
FTR, I don't think this should in any way be allocated by vr_shell_gl.cc.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_gl_thread.cc (right):

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_gl_thread.cc:38: // TODO: Clear up the init
order.  We should create the GL object first, as it
Elaborating:  This isn't a big deal, but we should do it correctly so that we
don't get sporadic failures on exit.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:1004:
vr_shell_renderer_->GetTexturedQuadRenderer()->Flush();
This may not be great, but I think this Flush optimization is not adding
anything right now.

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_renderer.cc (right):

https://codereview.chromium.org/2829653003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_renderer.cc:431: void
SkiaQuadRenderer::Draw(int texture_data_handle,
This is Flush(), refactored into a queue-less equivalent.  Not yet tested. 
Maybe we can refactor to reuse more code.

Powered by Google App Engine
This is Rietveld 408576698