Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2829633002: [ios] Create a new EG test suite for test depending on network. (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Create a new EG test suite for test depending on network. Add a new EG test suite ios_chrome_external_url_egtests for tests that have dependency on a working network connection (will be run on dedicated bots). Move all translate EG tests to the ios_chrome_external_url_egtests as TranslateManager checks whether the network connection is up before attempting the translation (note that all tests are moved even though referenced bug only mention two tests, as the other tests checks that the translation do not happens and succeed for incorrect reason). BUG=709131 Review-Url: https://codereview.chromium.org/2829633002 Cr-Commit-Position: refs/heads/master@{#465942} Committed: https://chromium.googlesource.com/chromium/src/+/9c339d21265de50d043f7ecb63ee96bf5fc221e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M ios/chrome/browser/translate/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M ios/chrome/browser/translate/translate_egtest.mm View 2 chunks +0 lines, -10 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 8 months ago (2017-04-19 13:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829633002/1
3 years, 8 months ago (2017-04-19 15:48:33 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-19 15:48:35 UTC) #10
sdefresne
Please take a look.
3 years, 8 months ago (2017-04-20 07:41:09 UTC) #12
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-20 07:43:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829633002/1
3 years, 8 months ago (2017-04-20 07:57:40 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 08:03:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c339d21265de50d043f7ecb63ee...

Powered by Google App Engine
This is Rietveld 408576698