Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/translate/BUILD.gn

Issue 2829633002: [ios] Create a new EG test suite for test depending on network. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/translate/translate_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/translate/BUILD.gn
diff --git a/ios/chrome/browser/translate/BUILD.gn b/ios/chrome/browser/translate/BUILD.gn
index 16beaecaf7e10cca0b9c566c8fddb51104742b7b..8663a2d097e52f7262bbce7e8ec04fb7d9ebf63c 100644
--- a/ios/chrome/browser/translate/BUILD.gn
+++ b/ios/chrome/browser/translate/BUILD.gn
@@ -73,7 +73,12 @@ source_set("unit_tests") {
]
}
-source_set("eg_tests") {
+# Those tests do not use external URLs but fail if the network is unavailable
+# as they explicitly check whether the network is up or not; it is not possible
+# to safely instantiate a net::NetworkChangeNotifier::DisableForTest to disable
+# those checks as this in not thread-safe. See http://crbug.com/709131 for more
+# details.
+source_set("external_url_eg_tests") {
testonly = true
sources = [
"translate_egtest.mm",
« no previous file with comments | « no previous file | ios/chrome/browser/translate/translate_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698